Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1398726 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2016-05-11 09:10 +0200 |
| Last post | 2016-05-11 21:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 09:10 +0200
Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Matthew Leach <matthew@mattleach.net> - 2016-05-11 20:30 +0200
Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-11 21:00 +0200
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-05-11 09:10 +0200 |
| Subject | [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board |
| Message-ID | <rxwro-3gT-27@gated-at.bofh.it> |
From: Matthew Leach <matthew@mattleach.net>
Enable the Origen's usb phy and ohci devices in the device tree. Also
add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
the AX88760 hub is powered.
Signed-off-by: Matthew Leach <matthew@mattleach.net>
[k.kozlowski: Extend nodes by label notation instead of path]
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 8bca699b7f20..4c59bdb0e6f3 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -77,12 +77,29 @@
clock-frequency = <24000000>;
};
};
+
};
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
+&exynos_usbphy {
+ status = "okay";
+};
+
+&ehci {
+ samsung,vbus-gpio = <&gpx3 5 1>;
+ status = "okay";
+
+ port@1{
+ status = "okay";
+ };
+ port@2 {
+ status = "okay";
+ };
+};
+
&fimd {
pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>;
pinctrl-names = "default";
--
1.9.1
[toc] | [next] | [standalone]
| From | Matthew Leach <matthew@mattleach.net> |
|---|---|
| Date | 2016-05-11 20:30 +0200 |
| Message-ID | <rxH3s-5o7-17@gated-at.bofh.it> |
| In reply to | #1398726 |
Hi Krzysztof, Sorry for not acting on the feedback sooner - I lost the email in my Inbox! I've tested the patch on my Origen board and it works fine. One small comment in-line. Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > From: Matthew Leach <matthew@mattleach.net> > > Enable the Origen's usb phy and ohci devices in the device tree. Also > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > the AX88760 hub is powered. > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > [k.kozlowski: Extend nodes by label notation instead of path] > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > index 8bca699b7f20..4c59bdb0e6f3 100644 > --- a/arch/arm/boot/dts/exynos4412-origen.dts > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > @@ -77,12 +77,29 @@ > clock-frequency = <24000000>; > }; > }; > + I think we could loose this line break? Thanks, -- Matt
[toc] | [prev] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-05-11 21:00 +0200 |
| Message-ID | <rxHwu-5FD-1@gated-at.bofh.it> |
| In reply to | #1399407 |
On Wed, May 11, 2016 at 07:18:31PM +0100, Matthew Leach wrote: > Hi Krzysztof, > > Sorry for not acting on the feedback sooner - I lost the email in my > Inbox! > > I've tested the patch on my Origen board and it works fine. One small > comment in-line. > > Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > > > From: Matthew Leach <matthew@mattleach.net> > > > > Enable the Origen's usb phy and ohci devices in the device tree. Also > > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > > the AX88760 hub is powered. > > > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > > [k.kozlowski: Extend nodes by label notation instead of path] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > > index 8bca699b7f20..4c59bdb0e6f3 100644 > > --- a/arch/arm/boot/dts/exynos4412-origen.dts > > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > > @@ -77,12 +77,29 @@ > > clock-frequency = <24000000>; > > }; > > }; > > + > > I think we could loose this line break? Yeah, that slipped through my fingers. Thanks for testing, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web