Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396116 > unrolled thread
| Started by | Greg Thelen <gthelen@google.com> |
|---|---|
| First post | 2016-05-06 23:30 +0200 |
| Last post | 2016-05-10 09:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] memcg: fix stale mem_cgroup_force_empty() comment Greg Thelen <gthelen@google.com> - 2016-05-06 23:30 +0200
Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Johannes Weiner <hannes@cmpxchg.org> - 2016-05-06 23:50 +0200
Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Michal Hocko <mhocko@kernel.org> - 2016-05-10 09:30 +0200
| From | Greg Thelen <gthelen@google.com> |
|---|---|
| Date | 2016-05-06 23:30 +0200 |
| Subject | [PATCH] memcg: fix stale mem_cgroup_force_empty() comment |
| Message-ID | <rvVtU-4cT-7@gated-at.bofh.it> |
commit f61c42a7d911 ("memcg: remove tasks/children test from
mem_cgroup_force_empty()") removed memory reparenting from the function.
Fix the function's comment.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
mm/memcontrol.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index fe787f5c41bd..19fd76168a05 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
}
/*
- * Reclaims as many pages from the given memcg as possible and moves
- * the rest to the parent.
+ * Reclaims as many pages from the given memcg as possible.
*
* Caller is responsible for holding css reference for memcg.
*/
--
2.8.0.rc3.226.g39d4020
[toc] | [next] | [standalone]
| From | Johannes Weiner <hannes@cmpxchg.org> |
|---|---|
| Date | 2016-05-06 23:50 +0200 |
| Message-ID | <rvVNg-4os-21@gated-at.bofh.it> |
| In reply to | #1396116 |
On Fri, May 06, 2016 at 02:23:30PM -0700, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
>
> Fix the function's comment.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
[toc] | [prev] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2016-05-10 09:30 +0200 |
| Message-ID | <rxahc-69M-9@gated-at.bofh.it> |
| In reply to | #1396116 |
On Fri 06-05-16 14:23:30, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
>
> Fix the function's comment.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memcontrol.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fe787f5c41bd..19fd76168a05 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
> }
>
> /*
> - * Reclaims as many pages from the given memcg as possible and moves
> - * the rest to the parent.
> + * Reclaims as many pages from the given memcg as possible.
> *
> * Caller is responsible for holding css reference for memcg.
> */
> --
> 2.8.0.rc3.226.g39d4020
--
Michal Hocko
SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web