Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment
Date	2016-05-10 09:30 +0200
Message-ID	<rxahc-69M-9@gated-at.bofh.it> (permalink)
References	<rvVtU-4cT-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 06-05-16 14:23:30, Greg Thelen wrote:
> commit f61c42a7d911 ("memcg: remove tasks/children test from
> mem_cgroup_force_empty()") removed memory reparenting from the function.
> 
> Fix the function's comment.
> 
> Signed-off-by: Greg Thelen <gthelen@google.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/memcontrol.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index fe787f5c41bd..19fd76168a05 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2636,8 +2636,7 @@ static inline bool memcg_has_children(struct mem_cgroup *memcg)
>  }
>  
>  /*
> - * Reclaims as many pages from the given memcg as possible and moves
> - * the rest to the parent.
> + * Reclaims as many pages from the given memcg as possible.
>   *
>   * Caller is responsible for holding css reference for memcg.
>   */
> -- 
> 2.8.0.rc3.226.g39d4020

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] memcg: fix stale mem_cgroup_force_empty() comment Greg Thelen <gthelen@google.com> - 2016-05-06 23:30 +0200
  Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Johannes Weiner <hannes@cmpxchg.org> - 2016-05-06 23:50 +0200
  Re: [PATCH] memcg: fix stale mem_cgroup_force_empty() comment Michal Hocko <mhocko@kernel.org> - 2016-05-10 09:30 +0200

csiph-web