Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399452 > unrolled thread

[PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

Started bySandhya Bankar <bankarsandhya512@gmail.com>
First post2016-05-11 21:40 +0200
Last post2016-05-11 21:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata(). Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-05-11 21:40 +0200

#1399452 — [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

FromSandhya Bankar <bankarsandhya512@gmail.com>
Date2016-05-11 21:40 +0200
Subject[PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().
Message-ID<rxI9c-6rJ-19@gated-at.bofh.it>
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the
device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/dwc2/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index ae41961..c76fade 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -69,7 +69,6 @@ static void dwc2_pci_remove(struct pci_dev *pci)
 	platform_device_unregister(glue->dwc2);
 	usb_phy_generic_unregister(glue->phy);
 	kfree(glue);
-	pci_set_drvdata(pci, NULL);
 }
 
 static int dwc2_pci_probe(struct pci_dev *pci,
-- 
1.8.3.4

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web