Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399452

[PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

From Sandhya Bankar <bankarsandhya512@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().
Date 2016-05-11 21:40 +0200
Message-ID <rxI9c-6rJ-19@gated-at.bofh.it> (permalink)
References <rxI9c-6rJ-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the
device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/dwc2/pci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index ae41961..c76fade 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -69,7 +69,6 @@ static void dwc2_pci_remove(struct pci_dev *pci)
 	platform_device_unregister(glue->dwc2);
 	usb_phy_generic_unregister(glue->phy);
 	kfree(glue);
-	pci_set_drvdata(pci, NULL);
 }
 
 static int dwc2_pci_probe(struct pci_dev *pci,
-- 
1.8.3.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata(). Sandhya Bankar <bankarsandhya512@gmail.com> - 2016-05-11 21:40 +0200

csiph-web