Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396360 > unrolled thread

[PATCH 1/2] Staging: android: ion: fixes use of typedef

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] Staging: android: ion: fixes use of typedef Thimo Braker <thibmorozier@gmail.com> - 2016-05-07 22:30 +0200
    Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef Greg KH <gregkh@linuxfoundation.org> - 2016-05-08 04:50 +0200
      Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef Thimo Braker <thibmorozier@gmail.com> - 2016-05-08 12:50 +0200

#1396360 — [PATCH 1/2] Staging: android: ion: fixes use of typedef

Fixes a checkpatch.pl warning about 'do not add new typedefs'

Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
---
 drivers/staging/android/uapi/ion.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 0a8e40f..77a46f0 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -20,8 +20,6 @@
 #include <linux/ioctl.h>
 #include <linux/types.h>
 
-typedef int ion_user_handle_t;
-
 /**
  * enum ion_heap_types - list of all possible types of heaps
  * @ION_HEAP_TYPE_SYSTEM:	 memory allocated via vmalloc
@@ -95,7 +93,7 @@ struct ion_allocation_data {
 	size_t align;
 	unsigned int heap_id_mask;
 	unsigned int flags;
-	ion_user_handle_t handle;
+	int handle;
 };
 
 /**
@@ -109,7 +107,7 @@ struct ion_allocation_data {
  * provides the file descriptor and the kernel returns the handle.
  */
 struct ion_fd_data {
-	ion_user_handle_t handle;
+	int handle;
 	int fd;
 };
 
@@ -118,7 +116,7 @@ struct ion_fd_data {
  * @handle:	a handle
  */
 struct ion_handle_data {
-	ion_user_handle_t handle;
+	int handle;
 };
 
 /**
-- 
2.1.4

[toc] | [next] | [standalone]

#1396374

On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote:
> Fixes a checkpatch.pl warning about 'do not add new typedefs'
> 
> Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
> ---
>  drivers/staging/android/uapi/ion.h | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..77a46f0 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,8 +20,6 @@
>  #include <linux/ioctl.h>
>  #include <linux/types.h>
>  
> -typedef int ion_user_handle_t;
> -

You just broke userspace :(

Sorry, you can't do this, be careful when touching files that cross the
user/kernel boundry (hint, they have uapi in the path), you have to know
exactly what you are doing when you do that.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1396410

On 8-5-2016 4:46, Greg KH wrote:
> You just broke userspace :(
> [..]
> (hint, they have uapi in the path)
I see I need to get used to some names ( now you say it, Uapi is quite 
logical ).
Thanks for the feedback.

Thimo B.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web