Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396374
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef |
| Date | 2016-05-08 04:50 +0200 |
| Message-ID | <rwmX8-5Ms-5@gated-at.bofh.it> (permalink) |
| References | <rwh1n-8vq-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote: > Fixes a checkpatch.pl warning about 'do not add new typedefs' > > Signed-off-by: Thimo Braker <thibmorozier@gmail.com> > --- > drivers/staging/android/uapi/ion.h | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 0a8e40f..77a46f0 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -20,8 +20,6 @@ > #include <linux/ioctl.h> > #include <linux/types.h> > > -typedef int ion_user_handle_t; > - You just broke userspace :( Sorry, you can't do this, be careful when touching files that cross the user/kernel boundry (hint, they have uapi in the path), you have to know exactly what you are doing when you do that. thanks, greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] Staging: android: ion: fixes use of typedef Thimo Braker <thibmorozier@gmail.com> - 2016-05-07 22:30 +0200
Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef Greg KH <gregkh@linuxfoundation.org> - 2016-05-08 04:50 +0200
Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef Thimo Braker <thibmorozier@gmail.com> - 2016-05-08 12:50 +0200
csiph-web