Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396378 > unrolled thread
| Started by | Bruno Carvalho <brunocarvalhofarias@gmail.com> |
|---|---|
| First post | 2016-05-08 05:30 +0200 |
| Last post | 2016-05-09 14:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Bruno Carvalho <brunocarvalhofarias@gmail.com> - 2016-05-08 05:30 +0200
Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Greg KH <gregkh@linuxfoundation.org> - 2016-05-09 14:30 +0200
| From | Bruno Carvalho <brunocarvalhofarias@gmail.com> |
|---|---|
| Date | 2016-05-08 05:30 +0200 |
| Subject | [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver |
| Message-ID | <rwnzP-6J5-5@gated-at.bofh.it> |
- alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index eb7e252..c0888f5 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
int ret;
for (i = 0; i < TTY_MAX_COUNT; i++) {
- tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
+ tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
+ TTY_DRIVER_REAL_RAW |
+ TTY_DRIVER_DYNAMIC_DEV);
if (!tty_driver)
return -ENOMEM;
--
2.1.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-09 14:30 +0200 |
| Subject | Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver |
| Message-ID | <rwStY-5zM-17@gated-at.bofh.it> |
| In reply to | #1396378 |
On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote:
> - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
>
> Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..c0888f5 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
> int ret;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> - tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
> + tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> + TTY_DRIVER_REAL_RAW |
> + TTY_DRIVER_DYNAMIC_DEV);
You just changed the logic here, previously we were passing in 0 for the
flags, now you are setting some to a different value, why?
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web