Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver
Date	2016-05-09 14:30 +0200
Message-ID	<rwStY-5zM-17@gated-at.bofh.it> (permalink)
References	<rwnzP-6J5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, May 07, 2016 at 11:29:14PM -0400, Bruno Carvalho wrote:
> - alloc_tty_driver() is deprecated. So it is replaced by tty_alloc_driver()
> 
> Signed-off-by: Bruno Carvalho <brunocarvalhofarias@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..c0888f5 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -306,7 +306,9 @@ int register_lte_tty_driver(void)
>  	int ret;
>  
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -		tty_driver = alloc_tty_driver(GDM_TTY_MINOR);
> +		tty_driver = tty_alloc_driver(GDM_TTY_MINOR,
> +					      TTY_DRIVER_REAL_RAW |
> +					      TTY_DRIVER_DYNAMIC_DEV);

You just changed the logic here, previously we were passing in 0 for the
flags, now you are setting some to a different value, why?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging/gdm724x: Use tty_alloc_driver instead of alloc_tty_driver Bruno Carvalho <brunocarvalhofarias@gmail.com> - 2016-05-08 05:30 +0200
  Re: [PATCH] staging/gdm724x: Use tty_alloc_driver instead of  alloc_tty_driver Greg KH <gregkh@linuxfoundation.org> - 2016-05-09 14:30 +0200

csiph-web