Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1396452 > unrolled thread

[PATCH] x86/cpu: Correct small issues in P4 erratum 037 code

Started byBorislav Petkov <bp@alien8.de>
First post2016-05-08 21:00 +0200
Last post2016-05-10 10:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] x86/cpu: Correct small issues in P4 erratum 037 code Borislav Petkov <bp@alien8.de> - 2016-05-08 21:00 +0200
    [tip:x86/cpu] x86/cpu: Correct comments and messages in P4 erratum  037 handling code tip-bot for Borislav Petkov <tipbot@zytor.com> - 2016-05-10 10:50 +0200

#1396452 — [PATCH] x86/cpu: Correct small issues in P4 erratum 037 code

FromBorislav Petkov <bp@alien8.de>
Date2016-05-08 21:00 +0200
Subject[PATCH] x86/cpu: Correct small issues in P4 erratum 037 code
Message-ID<rwC5P-3Ij-1@gated-at.bofh.it>
From: Borislav Petkov <bp@suse.de>

Remove the linebreak in the conditional and s/errata/erratum/ as the
singular is "erratum".

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
---
 arch/x86/kernel/cpu/intel.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index fcc0996afc9f..df9b912ff0fa 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -263,15 +263,14 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
 	}
 
 	/*
-	 * P4 Xeon errata 037 workaround.
+	 * P4 Xeon erratum 037 workaround.
 	 * Hardware prefetcher may cause stale data to be loaded into the cache.
 	 */
 	if ((c->x86 == 15) && (c->x86_model == 1) && (c->x86_mask == 1)) {
 		if (msr_set_bit(MSR_IA32_MISC_ENABLE,
-				MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE_BIT)
-		    > 0) {
+				MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE_BIT) > 0) {
 			pr_info("CPU: C0 stepping P4 Xeon detected.\n");
-			pr_info("CPU: Disabling hardware prefetching (Errata 037)\n");
+			pr_info("CPU: Disabling hardware prefetching (Erratum 037)\n");
 		}
 	}
 
-- 
2.7.3

[toc] | [next] | [standalone]


#1397858 — [tip:x86/cpu] x86/cpu: Correct comments and messages in P4 erratum 037 handling code

Fromtip-bot for Borislav Petkov <tipbot@zytor.com>
Date2016-05-10 10:50 +0200
Subject[tip:x86/cpu] x86/cpu: Correct comments and messages in P4 erratum 037 handling code
Message-ID<rxbwC-7k3-19@gated-at.bofh.it>
In reply to#1396452
Commit-ID:  f0133acc7d4835cfbb86393b7d2a4fba7519585b
Gitweb:     http://git.kernel.org/tip/f0133acc7d4835cfbb86393b7d2a4fba7519585b
Author:     Borislav Petkov <bp@suse.de>
AuthorDate: Sun, 8 May 2016 20:58:40 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 10 May 2016 10:05:03 +0200

x86/cpu: Correct comments and messages in P4 erratum 037 handling code

Remove the linebreak in the conditional and s/errata/erratum/ as the
singular is "erratum".

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1462733920-7224-1-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/intel.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index f71a349..5354080 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -263,15 +263,14 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
 	}
 
 	/*
-	 * P4 Xeon errata 037 workaround.
+	 * P4 Xeon erratum 037 workaround.
 	 * Hardware prefetcher may cause stale data to be loaded into the cache.
 	 */
 	if ((c->x86 == 15) && (c->x86_model == 1) && (c->x86_mask == 1)) {
 		if (msr_set_bit(MSR_IA32_MISC_ENABLE,
-				MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE_BIT)
-		    > 0) {
+				MSR_IA32_MISC_ENABLE_PREFETCH_DISABLE_BIT) > 0) {
 			pr_info("CPU: C0 stepping P4 Xeon detected.\n");
-			pr_info("CPU: Disabling hardware prefetching (Errata 037)\n");
+			pr_info("CPU: Disabling hardware prefetching (Erratum 037)\n");
 		}
 	}
 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web