Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395112 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-05-05 15:30 +0200 |
| Last post | 2016-05-09 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] qede: uninitialized variable in qede_start_xmit() Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-05 15:30 +0200
Re: [patch] qede: uninitialized variable in qede_start_xmit() David Miller <davem@davemloft.net> - 2016-05-09 05:40 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-05-05 15:30 +0200 |
| Subject | [patch] qede: uninitialized variable in qede_start_xmit() |
| Message-ID | <rvrvR-MH-29@gated-at.bofh.it> |
"data_split" was never set to false. It's just uninitialized.
Fixes: 2950219d87b0 ('qede: Add basic network device support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 60a61c3..d98f35e 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -429,7 +429,7 @@ netdev_tx_t qede_start_xmit(struct sk_buff *skb,
u8 xmit_type;
u16 idx;
u16 hlen;
- bool data_split;
+ bool data_split = false;
/* Get tx-queue context and netdev index */
txq_index = skb_get_queue_mapping(skb);
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-05-09 05:40 +0200 |
| Message-ID | <rwKd4-3N7-7@gated-at.bofh.it> |
| In reply to | #1395112 |
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 5 May 2016 16:21:30 +0300
> "data_split" was never set to false. It's just uninitialized.
>
> Fixes: 2950219d87b0 ('qede: Add basic network device support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web