[patch] qede: uninitialized variable in qede_start_xmit()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] qede: uninitialized variable in qede_start_xmit()
Date	2016-05-05 15:30 +0200
Message-ID	<rvrvR-MH-29@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

"data_split" was never set to false.  It's just uninitialized.

Fixes: 2950219d87b0 ('qede: Add basic network device support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 60a61c3..d98f35e 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -429,7 +429,7 @@ netdev_tx_t qede_start_xmit(struct sk_buff *skb,
 	u8 xmit_type;
 	u16 idx;
 	u16 hlen;
-	bool data_split;
+	bool data_split = false;
 
 	/* Get tx-queue context and netdev index */
 	txq_index = skb_get_queue_mapping(skb);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] qede: uninitialized variable in qede_start_xmit() Dan Carpenter <dan.carpenter@oracle.com> - 2016-05-05 15:30 +0200
  Re: [patch] qede: uninitialized variable in qede_start_xmit() David Miller <davem@davemloft.net> - 2016-05-09 05:40 +0200

csiph-web