Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395430 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2016-05-06 00:50 +0200 |
| Last post | 2016-05-06 23:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Andrew Lunn <andrew@lunn.ch> - 2016-05-06 03:20 +0200
Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 23:00 +0200
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-05-06 00:50 +0200 |
| Subject | [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol |
| Message-ID | <rvAfM-Dg-13@gated-at.bofh.it> |
6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA.
Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all
other mv88e6xxx drivers.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/Kconfig | 2 +-
drivers/net/dsa/mv88e6131.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index 4aaadce..7e01dce 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -17,7 +17,7 @@ config NET_DSA_MV88E6131
tristate "Marvell 88E6085/6095/6095F/6131 ethernet switch chip support"
depends on NET_DSA
select NET_DSA_MV88E6XXX
- select NET_DSA_TAG_DSA
+ select NET_DSA_TAG_EDSA
---help---
This enables support for the Marvell 88E6085/6095/6095F/6131
ethernet switch chips.
diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c
index cf7d710..81640f6 100644
--- a/drivers/net/dsa/mv88e6131.c
+++ b/drivers/net/dsa/mv88e6131.c
@@ -75,7 +75,7 @@ static const char *mv88e6131_drv_probe(struct device *dsa_dev,
}
struct dsa_switch_driver mv88e6131_switch_driver = {
- .tag_protocol = DSA_TAG_PROTO_DSA,
+ .tag_protocol = DSA_TAG_PROTO_EDSA,
.probe = mv88e6131_drv_probe,
.setup = mv88e6xxx_setup,
.set_addr = mv88e6xxx_set_addr,
--
2.8.2
[toc] | [next] | [standalone]
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Date | 2016-05-06 03:20 +0200 |
| Subject | Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol |
| Message-ID | <rvCAW-3eB-7@gated-at.bofh.it> |
| In reply to | #1395430 |
On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote: > 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA. > Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all > other mv88e6xxx drivers. Hi Vivien You might as well remove net/dsa/tag_dsa.c as well, since it is now unused. Please do that as a separate patch. Andrew
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2016-05-06 23:00 +0200 |
| Message-ID | <rvV0S-3D7-9@gated-at.bofh.it> |
| In reply to | #1395571 |
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote:
>> 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA.
>> Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all
>> other mv88e6xxx drivers.
>
> You might as well remove net/dsa/tag_dsa.c as well, since it is now
> unused. Please do that as a separate patch.
Why not, but isn't it a bit out of the scope of this patchset?
Thanks,
Vivien
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web