Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol
Date	2016-05-06 23:00 +0200
Message-ID	<rvV0S-3D7-9@gated-at.bofh.it> (permalink)
References	<rvAfL-Dg-3@gated-at.bofh.it> <rvAfM-Dg-13@gated-at.bofh.it> <rvCAW-3eB-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Thu, May 05, 2016 at 06:41:03PM -0400, Vivien Didelot wrote:
>> 6131 is the only driver to set the tag protocol to DSA_TAG_PROTO_DSA.
>> Since it works fine with DSA_TAG_PROTO_EDSA, change its value, like all
>> other mv88e6xxx drivers.
>
> You might as well remove net/dsa/tag_dsa.c as well, since it is now
> unused. Please do that as a separate patch.

Why not, but isn't it a bit out of the scope of this patchset?

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 00:50 +0200
  Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag  protocol Andrew Lunn <andrew@lunn.ch> - 2016-05-06 03:20 +0200
    Re: [RFC PATCH net-next 19/20] net: dsa: mv88e6xxx: factorize tag protocol Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-05-06 23:00 +0200

csiph-web