Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1392517 > unrolled thread
| Started by | Patryk Mezydlo <mezydlo.p@gmail.com> |
|---|---|
| First post | 2016-05-02 23:10 +0200 |
| Last post | 2016-05-03 00:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Patryk Mezydlo <mezydlo.p@gmail.com> - 2016-05-02 23:10 +0200
Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Greg KH <gregkh@linuxfoundation.org> - 2016-05-03 00:00 +0200
Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c mwelling@ieee.org - 2016-05-03 00:10 +0200
| From | Patryk Mezydlo <mezydlo.p@gmail.com> |
|---|---|
| Date | 2016-05-02 23:10 +0200 |
| Subject | [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c |
| Message-ID | <rutgm-2v3-9@gated-at.bofh.it> |
This is a patch to the dgnc_cls.c file that fixes up a brace warning found by the checkpatch.pl tool Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com> --- drivers/staging/dgnc/dgnc_cls.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 5e46ac8..f782904 100644 --- a/drivers/staging/dgnc/dgnc_cls.c +++ b/drivers/staging/dgnc/dgnc_cls.c @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch) /* Clear out UART and FIFO */ readb(&ch->ch_cls_uart->txrx); - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), + writeb((UART_FCR_ENABLE_FIFO + | UART_FCR_CLEAR_RCVR + | UART_FCR_CLEAR_XMIT), &ch->ch_cls_uart->isr_fcr); + udelay(10); ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); -- 2.1.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-05-03 00:00 +0200 |
| Message-ID | <ruu2K-3ht-13@gated-at.bofh.it> |
| In reply to | #1392517 |
On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote: > This is a patch to the dgnc_cls.c file that fixes up a brace > warning found by the checkpatch.pl tool > > Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com> > --- > drivers/staging/dgnc/dgnc_cls.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index 5e46ac8..f782904 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch) > /* Clear out UART and FIFO */ > readb(&ch->ch_cls_uart->txrx); > > - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), > + writeb((UART_FCR_ENABLE_FIFO > + | UART_FCR_CLEAR_RCVR > + | UART_FCR_CLEAR_XMIT), > &ch->ch_cls_uart->isr_fcr); > + This isn't a "brace warning" fix. And why add another blank line?
[toc] | [prev] | [next] | [standalone]
| From | mwelling@ieee.org |
|---|---|
| Date | 2016-05-03 00:10 +0200 |
| Message-ID | <ruucq-3Fl-7@gated-at.bofh.it> |
| In reply to | #1392540 |
On May 2, 2016 4:55:05 PM CDT, Greg KH <gregkh@linuxfoundation.org> wrote: >On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote: >> This is a patch to the dgnc_cls.c file that fixes up a brace >> warning found by the checkpatch.pl tool >> >> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com> >> --- >> drivers/staging/dgnc/dgnc_cls.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/dgnc/dgnc_cls.c >b/drivers/staging/dgnc/dgnc_cls.c >> index 5e46ac8..f782904 100644 >> --- a/drivers/staging/dgnc/dgnc_cls.c >> +++ b/drivers/staging/dgnc/dgnc_cls.c >> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t >*ch) >> /* Clear out UART and FIFO */ >> readb(&ch->ch_cls_uart->txrx); >> >> - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | >UART_FCR_CLEAR_XMIT), >> + writeb((UART_FCR_ENABLE_FIFO >> + | UART_FCR_CLEAR_RCVR >> + | UART_FCR_CLEAR_XMIT), >> &ch->ch_cls_uart->isr_fcr); >> + > >This isn't a "brace warning" fix. > >And why add another blank line? Patryk, Please post the checkpatch warning that was output so we can see what exactly was attempted to be corrected. Regards, Michael
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web