Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c

From	mwelling@ieee.org
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c
Date	2016-05-03 00:10 +0200
Message-ID	<ruucq-3Fl-7@gated-at.bofh.it> (permalink)
References	<rutgm-2v3-9@gated-at.bofh.it> <ruu2K-3ht-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On May 2, 2016 4:55:05 PM CDT, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote:
>> This is a patch to the dgnc_cls.c file that fixes up a brace
>> warning found by the checkpatch.pl tool
>> 
>> Signed-off-by: Patryk Mezydlo <mezydlo.p@gmail.com>
>> ---
>>  drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/staging/dgnc/dgnc_cls.c
>b/drivers/staging/dgnc/dgnc_cls.c
>> index 5e46ac8..f782904 100644
>> --- a/drivers/staging/dgnc/dgnc_cls.c
>> +++ b/drivers/staging/dgnc/dgnc_cls.c
>> @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t
>*ch)
>>  	/* Clear out UART and FIFO */
>>  	readb(&ch->ch_cls_uart->txrx);
>>  
>> -	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR |
>UART_FCR_CLEAR_XMIT),
>> +	writeb((UART_FCR_ENABLE_FIFO
>> +		| UART_FCR_CLEAR_RCVR
>> +		| UART_FCR_CLEAR_XMIT),
>>  	       &ch->ch_cls_uart->isr_fcr);
>> +
>
>This isn't a "brace warning" fix.
>
>And why add another blank line?

Patryk,

Please post the checkpatch warning that was output so we can see what exactly was attempted to be corrected. 

Regards,

Michael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Patryk Mezydlo <mezydlo.p@gmail.com> - 2016-05-02 23:10 +0200
  Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Greg KH <gregkh@linuxfoundation.org> - 2016-05-03 00:00 +0200
    Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c mwelling@ieee.org - 2016-05-03 00:10 +0200

csiph-web