Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1392518 > unrolled thread

Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data

Started byPavel Machek <pavel@ucw.cz>
First post2016-05-02 23:10 +0200
Last post2016-05-02 23:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 01/12] staging/android: remove redundant comments on  sync_merge_data Pavel Machek <pavel@ucw.cz> - 2016-05-02 23:10 +0200
    Re: [PATCH 01/12] staging/android: remove redundant comments on  sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-05-02 23:20 +0200

#1392518 — Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data

FromPavel Machek <pavel@ucw.cz>
Date2016-05-02 23:10 +0200
SubjectRe: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data
Message-ID<rutgn-2v3-17@gated-at.bofh.it>
On Wed 2016-04-27 13:27:08, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> struct sync_merge_data already have documentation on top of the
> struct definition. No need to duplicate it.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

> @@ -33,8 +33,8 @@ struct sync_merge_data {
>  /**
>   * struct sync_fence_info - detailed fence information
>   * @obj_name:		name of parent sync_timeline
> - * @driver_name:	name of driver implementing the parent
> - * @status:		status of the fence 0:active 1:signaled <0:error
> +* @driver_name:	name of driver implementing the parent
> +* @status:		status of the fence 0:active 1:signaled <0:error

The whitespace (or mail client configuration?) looks wrong here.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]


#1392519

FromGustavo Padovan <gustavo@padovan.org>
Date2016-05-02 23:20 +0200
Message-ID<rutq2-2Aa-1@gated-at.bofh.it>
In reply to#1392518
2016-05-02 Pavel Machek <pavel@ucw.cz>:

> On Wed 2016-04-27 13:27:08, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > struct sync_merge_data already have documentation on top of the
> > struct definition. No need to duplicate it.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> > @@ -33,8 +33,8 @@ struct sync_merge_data {
> >  /**
> >   * struct sync_fence_info - detailed fence information
> >   * @obj_name:		name of parent sync_timeline
> > - * @driver_name:	name of driver implementing the parent
> > - * @status:		status of the fence 0:active 1:signaled <0:error
> > +* @driver_name:	name of driver implementing the parent
> > +* @status:		status of the fence 0:active 1:signaled <0:error
> 
> The whitespace (or mail client configuration?) looks wrong here.

this has been fixed in v2 already and Greg pulled everything into
staging next already.

	Gustavo

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web