Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1392518

Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data
Date 2016-05-02 23:10 +0200
Message-ID <rutgn-2v3-17@gated-at.bofh.it> (permalink)
References <rsAvD-47z-3@gated-at.bofh.it> <rsAFj-4bo-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed 2016-04-27 13:27:08, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> struct sync_merge_data already have documentation on top of the
> struct definition. No need to duplicate it.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

> @@ -33,8 +33,8 @@ struct sync_merge_data {
>  /**
>   * struct sync_fence_info - detailed fence information
>   * @obj_name:		name of parent sync_timeline
> - * @driver_name:	name of driver implementing the parent
> - * @status:		status of the fence 0:active 1:signaled <0:error
> +* @driver_name:	name of driver implementing the parent
> +* @status:		status of the fence 0:active 1:signaled <0:error

The whitespace (or mail client configuration?) looks wrong here.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 01/12] staging/android: remove redundant comments on  sync_merge_data Pavel Machek <pavel@ucw.cz> - 2016-05-02 23:10 +0200
  Re: [PATCH 01/12] staging/android: remove redundant comments on  sync_merge_data Gustavo Padovan <gustavo@padovan.org> - 2016-05-02 23:20 +0200

csiph-web