Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1393801 > unrolled thread

[PATCH] infoleak fix1 in signal

Back to article view | Back to linux.kernel

Contents

  [PATCH] infoleak fix1 in signal Kangjie Lu <kangjielu@gmail.com> - 2016-05-03 22:40 +0200
    Re: [PATCH] infoleak fix1 in signal Oleg Nesterov <oleg@redhat.com> - 2016-05-04 12:40 +0200

#1393801 — [PATCH] infoleak fix1 in signal

The stack object “info” has a total size of 128 bytes; however,
only 28 bytes are initialized. The remaining uninitialized bytes
are sent to userland via send_signal.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 kernel/signal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/signal.c b/kernel/signal.c
index aa9bf00..f40f0b3 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 			sig = SIGCHLD;
 	}
 
+	memset(&info, 0, sizeof(info));
 	info.si_signo = sig;
 	info.si_errno = 0;
 	/*
-- 
1.9.1

[toc] | [next] | [standalone]

#1394141

On 05/03, Kangjie Lu wrote:
>
> The stack object “info” has a total size of 128 bytes; however,
> only 28 bytes are initialized. The remaining uninitialized bytes
> are sent to userland via send_signal.

Not really, please see copy_siginfo_to_user(), case(__SI_CHLD). All members
copied to user-space are initialized afaics.

> @@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  			sig = SIGCHLD;
>  	}
>
> +	memset(&info, 0, sizeof(info));

looks like a false alarm to me.

Oleg.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web