Re: [PATCH] infoleak fix1 in signal

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] infoleak fix1 in signal
Date	2016-05-04 12:40 +0200
Message-ID	<rv2nM-28B-13@gated-at.bofh.it> (permalink)
References	<ruPgT-6BH-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/03, Kangjie Lu wrote:
>
> The stack object “info” has a total size of 128 bytes; however,
> only 28 bytes are initialized. The remaining uninitialized bytes
> are sent to userland via send_signal.

Not really, please see copy_siginfo_to_user(), case(__SI_CHLD). All members
copied to user-space are initialized afaics.

> @@ -1594,6 +1594,7 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
>  			sig = SIGCHLD;
>  	}
>
> +	memset(&info, 0, sizeof(info));

looks like a false alarm to me.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] infoleak fix1 in signal Kangjie Lu <kangjielu@gmail.com> - 2016-05-03 22:40 +0200
  Re: [PATCH] infoleak fix1 in signal Oleg Nesterov <oleg@redhat.com> - 2016-05-04 12:40 +0200

csiph-web