Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391383 > unrolled thread

Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES

Started byDave Hansen <dave.hansen@linux.intel.com>
First post2016-04-29 22:20 +0200
Last post2016-04-29 22:50 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:20 +0200
    Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Borislav Petkov <bp@suse.de> - 2016-04-29 22:40 +0200
      Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Borislav Petkov <bp@suse.de> - 2016-04-29 22:50 +0200
      Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:50 +0200

#1391383 — Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES

FromDave Hansen <dave.hansen@linux.intel.com>
Date2016-04-29 22:20 +0200
SubjectRe: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES
Message-ID<rtn3k-3Ce-9@gated-at.bofh.it>
On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> +	if (boot_cpu_has(X86_FEATURE_XSAVES)) {
> +		ret = copyout_from_xsaves(pos, count, kbuf, ubuf, xsave);

On a higher level, we really should stop using
"boot_cpu_has(X86_FEATURE_XSAVES)" as a proxy for "the kernel XSAVE
buffer is in the XSAVES format".  I think our use of the _hardware_
CPUID bit is confusing at least the KVM folks.

We probably want a software X86_FEATURE_OS_XSAVES or something.

[toc] | [next] | [standalone]


#1391409

FromBorislav Petkov <bp@suse.de>
Date2016-04-29 22:40 +0200
Message-ID<rtnmG-3LT-15@gated-at.bofh.it>
In reply to#1391383
On Fri, Apr 29, 2016 at 01:16:59PM -0700, Dave Hansen wrote:
> We probably want a software X86_FEATURE_OS_XSAVES or something.

... or a simple variable.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

[toc] | [prev] | [next] | [standalone]


#1391413

FromBorislav Petkov <bp@suse.de>
Date2016-04-29 22:50 +0200
Message-ID<rtnwm-3Q2-9@gated-at.bofh.it>
In reply to#1391409
On Fri, Apr 29, 2016 at 01:40:51PM -0700, Dave Hansen wrote:
> I think we do some instruction patching based on it, so I was just
> suggesting the software X86_FEATURE because it would plug in to the
> existing scheme easier.

Ah ok, that's fine then.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

[toc] | [prev] | [next] | [standalone]


#1391421

FromDave Hansen <dave.hansen@linux.intel.com>
Date2016-04-29 22:50 +0200
Message-ID<rtnwm-3Q2-11@gated-at.bofh.it>
In reply to#1391409
On 04/29/2016 01:38 PM, Borislav Petkov wrote:
> On Fri, Apr 29, 2016 at 01:16:59PM -0700, Dave Hansen wrote:
>> > We probably want a software X86_FEATURE_OS_XSAVES or something.
> ... or a simple variable.

I think we do some instruction patching based on it, so I was just
suggesting the software X86_FEATURE because it would plug in to the
existing scheme easier.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web