Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391383

Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES

From Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES
Date 2016-04-29 22:20 +0200
Message-ID <rtn3k-3Ce-9@gated-at.bofh.it> (permalink)
References <r92ut-2hO-1@gated-at.bofh.it> <r92uu-2hO-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 03/04/2016 10:12 AM, Yu-cheng Yu wrote:
> +	if (boot_cpu_has(X86_FEATURE_XSAVES)) {
> +		ret = copyout_from_xsaves(pos, count, kbuf, ubuf, xsave);

On a higher level, we really should stop using
"boot_cpu_has(X86_FEATURE_XSAVES)" as a proxy for "the kernel XSAVE
buffer is in the XSAVES format".  I think our use of the _hardware_
CPUID bit is confusing at least the KVM folks.

We probably want a software X86_FEATURE_OS_XSAVES or something.

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:20 +0200
  Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Borislav Petkov <bp@suse.de> - 2016-04-29 22:40 +0200
    Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Borislav Petkov <bp@suse.de> - 2016-04-29 22:50 +0200
    Re: [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-04-29 22:50 +0200

csiph-web