Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391099 > unrolled thread

Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations Johan Hovold <johan@kernel.org> - 2016-04-29 15:00 +0200
    Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations Grigori Goronzy <greg@chown.ath.cx> - 2016-04-29 17:20 +0200

#1391099 — Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

On Fri, Apr 15, 2016 at 11:14:07PM +0200, Grigori Goronzy wrote:
> Use the correct types and sizes.
> 
> v2: use u8 shorthand for unsigned char.

Pleas place commit logs below the cut-off line (---).

> Signed-off-by: Grigori Goronzy <greg@chown.ath.cx>
> ---
>  drivers/usb/serial/ch341.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
> index db4b561..95c8a40 100644
> --- a/drivers/usb/serial/ch341.c
> +++ b/drivers/usb/serial/ch341.c
> @@ -115,7 +115,7 @@ static int ch341_control_out(struct usb_device *dev, u8 request,
>  
>  static int ch341_control_in(struct usb_device *dev,
>  			    u8 request, u16 value, u16 index,
> -			    char *buf, unsigned bufsize)
> +			    u8 *buf, unsigned bufsize)

Just use void * for the buffer parameter.

>  {
>  	int r;
>  
> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device *dev, u8 control)
>  
>  static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv)
>  {
> -	char *buffer;
> +	unsigned char *buffer;
>  	int r;
> -	const unsigned size = 8;
> +	const unsigned size = 2;

Did you reply to Oliver's comment about this change? Are you sure this
won't break some old device expecting to be asked for eight bytes even
if only two are returned?

I suggest breaking this out into a separate patch either way.

Thanks,
Johan

[toc] | [next] | [standalone]

#1391247

On 2016-04-29 14:52, Johan Hovold wrote:
>> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device 
>> *dev, u8 control)
>> 
>>  static int ch341_get_status(struct usb_device *dev, struct 
>> ch341_private *priv)
>>  {
>> -	char *buffer;
>> +	unsigned char *buffer;
>>  	int r;
>> -	const unsigned size = 8;
>> +	const unsigned size = 2;
> 
> Did you reply to Oliver's comment about this change? Are you sure this
> won't break some old device expecting to be asked for eight bytes even
> if only two are returned?
> 

I'll just drop this change.

Grigori

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web