Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations

From	Grigori Goronzy <greg@chown.ath.cx>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations
Date	2016-04-29 17:20 +0200
Message-ID	<rtin1-8fU-39@gated-at.bofh.it> (permalink)
References	<rojjH-119-3@gated-at.bofh.it> <rojjI-119-23@gated-at.bofh.it> <rtgby-69i-53@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-04-29 14:52, Johan Hovold wrote:
>> @@ -168,9 +168,9 @@ static int ch341_set_handshake(struct usb_device 
>> *dev, u8 control)
>> 
>>  static int ch341_get_status(struct usb_device *dev, struct 
>> ch341_private *priv)
>>  {
>> -	char *buffer;
>> +	unsigned char *buffer;
>>  	int r;
>> -	const unsigned size = 8;
>> +	const unsigned size = 2;
> 
> Did you reply to Oliver's comment about this change? Are you sure this
> won't break some old device expecting to be asked for eight bytes even
> if only two are returned?
> 

I'll just drop this change.

Grigori

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations Johan Hovold <johan@kernel.org> - 2016-04-29 15:00 +0200
  Re: [PATCH v4 04/13] USB: ch341: fix USB buffer allocations Grigori Goronzy <greg@chown.ath.cx> - 2016-04-29 17:20 +0200

csiph-web