Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391654 > unrolled thread

Re: [PATCH] rtc: stmp3xxx: check for failure

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] rtc: stmp3xxx: check for failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 20:50 +0200

#1391654 — Re: [PATCH] rtc: stmp3xxx: check for failure

On Fri, Apr 15, 2016 at 11:07:15PM +0200, Alexandre Belloni wrote:
> Hi,
> 
> On 11/04/2016 at 22:03:55 +0530, Sudip Mukherjee wrote :
> > stmp3xxx_wdt_register() can fail as platform_device_alloc() or
> > platform_device_add() can fail. Lets check for the return value from
> > both platform_device_alloc() and platform_device_add() and return the
> > error value accordingly which is now propagated from probe.
> > 
> 
> Well, this may have been intentional. The RTC doesn't need the watchdog
> driver to be present to work correctly. However, I agree that failing
> silently is not nice.
> 
> Did you have any particular issue? Maybe simply adding a dev_err() or
> two would be fine.

I didnot have any particular issue. I will send a new patch with some
error message there.

regards
sudip

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web