Re: [PATCH] rtc: stmp3xxx: check for failure

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] rtc: stmp3xxx: check for failure
Date	2016-04-30 20:50 +0200
Message-ID	<rtI7L-3Pm-3@gated-at.bofh.it> (permalink)
References	<rmN2y-py-15@gated-at.bofh.it> <roja2-X1-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 15, 2016 at 11:07:15PM +0200, Alexandre Belloni wrote:
> Hi,
> 
> On 11/04/2016 at 22:03:55 +0530, Sudip Mukherjee wrote :
> > stmp3xxx_wdt_register() can fail as platform_device_alloc() or
> > platform_device_add() can fail. Lets check for the return value from
> > both platform_device_alloc() and platform_device_add() and return the
> > error value accordingly which is now propagated from probe.
> > 
> 
> Well, this may have been intentional. The RTC doesn't need the watchdog
> driver to be present to work correctly. However, I agree that failing
> silently is not nice.
> 
> Did you have any particular issue? Maybe simply adding a dev_err() or
> two would be fine.

I didnot have any particular issue. I will send a new patch with some
error message there.

regards
sudip

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] rtc: stmp3xxx: check for failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 20:50 +0200

csiph-web