Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391636 > unrolled thread

Re: [PATCH] char: xillybus: use devm_add_action_or_reset

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] char: xillybus: use devm_add_action_or_reset Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 18:20 +0200

#1391636 — Re: [PATCH] char: xillybus: use devm_add_action_or_reset

On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
> 
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
> 
>     if (rc)
>         return rc;
> 
>     return 0;
> 
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.

ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.

regards
sudip

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web