Re: [PATCH] char: xillybus: use devm_add_action_or_reset

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] char: xillybus: use devm_add_action_or_reset
Date	2016-04-30 18:20 +0200
Message-ID	<rtFMC-27i-1@gated-at.bofh.it> (permalink)
References	<rrVLP-3EY-1@gated-at.bofh.it> <rs8J4-691-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
> 
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
> 
>     if (rc)
>         return rc;
> 
>     return 0;
> 
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.

ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.

regards
sudip

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] char: xillybus: use devm_add_action_or_reset Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 18:20 +0200

csiph-web