Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1390562 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2016-04-28 23:40 +0200 |
| Last post | 2016-04-28 23:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address Rob Herring <robh@kernel.org> - 2016-04-28 23:40 +0200
Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address "Franklin S Cooper Jr." <fcooper@ti.com> - 2016-04-28 23:50 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2016-04-28 23:40 +0200 |
| Subject | Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address |
| Message-ID | <rt1Pd-2H9-15@gated-at.bofh.it> |
On Tue, Apr 26, 2016 at 05:36:44PM -0500, Franklin S Cooper Jr wrote:
> Replace unit address from 0 to the proper physical address.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-tiecap.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> index 788da6c..1b7eec5 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> @@ -16,21 +16,21 @@ Optional properties:
>
> Example:
>
> -ecap0: ecap@0 { /* ECAP on am33xx */
> +ecap0: ecap@48300100 { /* ECAP on am33xx */
> compatible = "ti,am33xx-ecap";
> #pwm-cells = <3>;
> reg = <0x48300100 0x80>;
> ti,hwmods = "ecap0";
> };
>
> -ecap0: ecap@0 { /* ECAP on am4372 */
> +ecap0: ecap@48300100 { /* ECAP on am4372 */
> compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
> #pwm-cells = <3>;
> reg = <0x48300100 0x80>;
> ti,hwmods = "ecap0";
> };
>
> -ecap0: ecap@0 { /* ECAP on da850 */
> +ecap0: ecap@1f06000 { /* ECAP on da850 */
> compatible = "ti,da850-ecap", "ti,am33xx-ecap";
> #pwm-cells = <3>;
> reg = <0x306000 0x80>;
These still don't match.
Rob
> --
> 2.7.0
>
[toc] | [next] | [standalone]
| From | "Franklin S Cooper Jr." <fcooper@ti.com> |
|---|---|
| Date | 2016-04-28 23:50 +0200 |
| Subject | Re: [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address |
| Message-ID | <rt1YS-2LF-1@gated-at.bofh.it> |
| In reply to | #1390562 |
On 04/28/2016 04:31 PM, Rob Herring wrote:
> On Tue, Apr 26, 2016 at 05:36:44PM -0500, Franklin S Cooper Jr wrote:
>> Replace unit address from 0 to the proper physical address.
>>
>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm-tiecap.txt | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> index 788da6c..1b7eec5 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
>> @@ -16,21 +16,21 @@ Optional properties:
>>
>> Example:
>>
>> -ecap0: ecap@0 { /* ECAP on am33xx */
>> +ecap0: ecap@48300100 { /* ECAP on am33xx */
>> compatible = "ti,am33xx-ecap";
>> #pwm-cells = <3>;
>> reg = <0x48300100 0x80>;
>> ti,hwmods = "ecap0";
>> };
>>
>> -ecap0: ecap@0 { /* ECAP on am4372 */
>> +ecap0: ecap@48300100 { /* ECAP on am4372 */
>> compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
>> #pwm-cells = <3>;
>> reg = <0x48300100 0x80>;
>> ti,hwmods = "ecap0";
>> };
>>
>> -ecap0: ecap@0 { /* ECAP on da850 */
>> +ecap0: ecap@1f06000 { /* ECAP on da850 */
>> compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>> #pwm-cells = <3>;
>> reg = <0x306000 0x80>;
>
> These still don't match.
>
> Rob
I apologize you made a similar comment in the past but I misinterpreted
it recently which is why I made the same mistake again. I'll fix it.
Any issue with my response to your patch two comment for why I did
things the way I did? If so I can fix it when I send my new rev.
>
>> --
>> 2.7.0
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web