Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389044 > unrolled thread

[PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

Started byYU Bo <tsu.yubo@gmail.com>
First post2016-04-27 15:30 +0200
Last post2016-04-27 16:40 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging:xgifb: Fix Comparisons should place the constant on  the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 15:30 +0200
    Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-27 16:10 +0200
      Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 16:20 +0200
      Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 16:40 +0200

#1389044 — [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

FromYU Bo <tsu.yubo@gmail.com>
Date2016-04-27 15:30 +0200
Subject[PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Message-ID<rsxHt-1R0-27@gated-at.bofh.it>
Fixed checkpatch.pl's warning 'Comparisons should place the constant on
the right side of the test'

Signed-off-by: YU Bo <tsu.yubo@gmail.com>
---
  drivers/staging/xgifb/vb_setmode.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 50c8ea4f5ab7..8bf253c224ad 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
  		if (pVBInfo->LCDInfo & EnableScalingLCD)
  			tempdx &= (~PanelResInfo);

-		if (table[i].PANELID == tempdx) {
+		if (tempdx == table[i].PANELID) {
  			tempbx = table[i].MASK;
  			tempdx = pVBInfo->LCDInfo;

@@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const

  	i = 0;
  	while (Tap4TimingPtr[i].DE != 0xFFFF) {
-		if (Tap4TimingPtr[i].DE == tempax)
+		if (tempax == Tap4TimingPtr[i].DE)
  			break;
  		i++;
  	}
--
1.7.10.4

[toc] | [next] | [standalone]

#1389101 — Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

FromDan Carpenter <dan.carpenter@oracle.com>
Date2016-04-27 16:10 +0200
SubjectRe: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Message-ID<rsykb-2uQ-33@gated-at.bofh.it>
In reply to#1389044
On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:
> Fixed checkpatch.pl's warning 'Comparisons should place the constant on
> the right side of the test'
> 
> Signed-off-by: YU Bo <tsu.yubo@gmail.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4f5ab7..8bf253c224ad 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>  		if (pVBInfo->LCDInfo & EnableScalingLCD)
>  			tempdx &= (~PanelResInfo);
> 
> -		if (table[i].PANELID == tempdx) {
> +		if (tempdx == table[i].PANELID) {

I don't understand why checkpatch is complaining about this one...  It
seems like a false positive.  Maybe it's because .PANELID is a rubbish
variable name.

regards,
dan carpetner

[toc] | [prev] | [next] | [standalone]

#1389113 — Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

FromYU Bo <tsu.yubo@gmail.com>
Date2016-04-27 16:20 +0200
SubjectRe: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Message-ID<rsytQ-2zP-27@gated-at.bofh.it>
In reply to#1389101
On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote:
>On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:
>> Fixed checkpatch.pl's warning 'Comparisons should place the constant on
>> the right side of the test'
>>
>> Signed-off-by: YU Bo <tsu.yubo@gmail.com>
>> ---
>>  drivers/staging/xgifb/vb_setmode.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
>> index 50c8ea4f5ab7..8bf253c224ad 100644
>> --- a/drivers/staging/xgifb/vb_setmode.c
>> +++ b/drivers/staging/xgifb/vb_setmode.c
>> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>>  		if (pVBInfo->LCDInfo & EnableScalingLCD)
>>  			tempdx &= (~PanelResInfo);
>>
>> -		if (table[i].PANELID == tempdx) {
>> +		if (tempdx == table[i].PANELID) {
>
>I don't understand why checkpatch is complaining about this one...  It
>seems like a false positive.  Maybe it's because .PANELID is a rubbish
>variable name.
Yes.I am also confused when i'm ready to submit the patch.Obviously
'temp[ad]x' is variable.My first patch have to wait a long time.:)
>
>regards,
>dan carpetner
>

[toc] | [prev] | [next] | [standalone]

#1389149 — Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

FromYU Bo <tsu.yubo@gmail.com>
Date2016-04-27 16:40 +0200
SubjectRe: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Message-ID<rsyNe-2L2-61@gated-at.bofh.it>
In reply to#1389101
On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote:
>On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:
>> Fixed checkpatch.pl's warning 'Comparisons should place the constant on
>> the right side of the test'
>>
>> Signed-off-by: YU Bo <tsu.yubo@gmail.com>
>> ---
>>  drivers/staging/xgifb/vb_setmode.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
>> index 50c8ea4f5ab7..8bf253c224ad 100644
>> --- a/drivers/staging/xgifb/vb_setmode.c
>> +++ b/drivers/staging/xgifb/vb_setmode.c
>> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>>  		if (pVBInfo->LCDInfo & EnableScalingLCD)
>>  			tempdx &= (~PanelResInfo);
>>
>> -		if (table[i].PANELID == tempdx) {
>> +		if (tempdx == table[i].PANELID) {
>
>I don't understand why checkpatch is complaining about this one...  It
>seems like a false positive.  Maybe it's because .PANELID is a rubbish
>variable name.
Here, it seems like to notice upper case identifier on the left.

	https://lkml.org/lkml/diff/2015/8/27/469/1
Best Regards,
>
>regards,
>dan carpetner
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web