Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

From	YU Bo <tsu.yubo@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Date	2016-04-27 16:40 +0200
Message-ID	<rsyNe-2L2-61@gated-at.bofh.it> (permalink)
References	<rsxHt-1R0-27@gated-at.bofh.it> <rsykb-2uQ-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote:
>On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote:
>> Fixed checkpatch.pl's warning 'Comparisons should place the constant on
>> the right side of the test'
>>
>> Signed-off-by: YU Bo <tsu.yubo@gmail.com>
>> ---
>>  drivers/staging/xgifb/vb_setmode.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
>> index 50c8ea4f5ab7..8bf253c224ad 100644
>> --- a/drivers/staging/xgifb/vb_setmode.c
>> +++ b/drivers/staging/xgifb/vb_setmode.c
>> @@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,
>>  		if (pVBInfo->LCDInfo & EnableScalingLCD)
>>  			tempdx &= (~PanelResInfo);
>>
>> -		if (table[i].PANELID == tempdx) {
>> +		if (tempdx == table[i].PANELID) {
>
>I don't understand why checkpatch is complaining about this one...  It
>seems like a false positive.  Maybe it's because .PANELID is a rubbish
>variable name.
Here, it seems like to notice upper case identifier on the left.

	https://lkml.org/lkml/diff/2015/8/27/469/1
Best Regards,
>
>regards,
>dan carpetner
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:xgifb: Fix Comparisons should place the constant on  the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 15:30 +0200
  Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-27 16:10 +0200
    Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 16:20 +0200
    Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant  on the right side of the test warning YU Bo <tsu.yubo@gmail.com> - 2016-04-27 16:40 +0200

csiph-web