Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1388907 > unrolled thread

Re: [PATCH] of: Add stub for of_get_next_parent()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] of: Add stub for of_get_next_parent() Arnd Bergmann <arnd@arndb.de> - 2016-04-27 13:20 +0200
    Re: [PATCH] of: Add stub for of_get_next_parent() Thierry Reding <treding@nvidia.com> - 2016-04-27 17:10 +0200

#1388907 — Re: [PATCH] of: Add stub for of_get_next_parent()

On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> Fixes a compiler error:
> 
> drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
>     parent = of_get_next_parent(parent);
>                  ^
> 
> Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Yes, this works. I have submitted an alternative patch to fix the
build error, changing the PHY core to not use any of the OF interfaces
if CONFIG_OF is disabled.

We can also have both.

Acked-by: Arnd Bergmann <arnd@arndb.de>

[toc] | [next] | [standalone]

#1389207

[Multipart message — attachments visible in raw view] — view raw

On Wed, Apr 27, 2016 at 01:13:33PM +0200, Arnd Bergmann wrote:
> On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> > Fixes a compiler error:
> > 
> > drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> > drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> > ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
> >     parent = of_get_next_parent(parent);
> >                  ^
> > 
> > Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Yes, this works. I have submitted an alternative patch to fix the
> build error, changing the PHY core to not use any of the OF interfaces
> if CONFIG_OF is disabled.
> 
> We can also have both.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

I'm thinking of simply open-coding this for now, to avoid the use of
of_get_next_parent(). This is part of a set of patches that has gone
through countless revisions over the past two years and the timing
is such that adding yet another dependency will likely make it miss
the next cycle again. I'd really like to avoid that.

If nobody objects I'll volunteer to refactor this after v4.7-rc1.

Alternatively, perhaps Rob can give a very quick Acked-by on the
of_get_next_parent() addition, then I might still have time to take
this through one or two linux-next releases before sending out the
pull requests around the end of the week.

Thierry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web