Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1388907

Re: [PATCH] of: Add stub for of_get_next_parent()

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] of: Add stub for of_get_next_parent()
Date 2016-04-27 13:20 +0200
Message-ID <rsvFE-dE-27@gated-at.bofh.it> (permalink)
References <rsvFE-dE-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wednesday 27 April 2016 14:11:40 Heikki Krogerus wrote:
> Fixes a compiler error:
> 
> drivers/phy/phy-core.c: In function ‘__of_phy_provider_register’:
> drivers/phy/phy-core.c:848:13: error: implicit declaration of function
> ‘of_get_next_parent’ [-Werror=implicit-function-declaration]
>     parent = of_get_next_parent(parent);
>                  ^
> 
> Fixes: 2f7600bc981c ("phy: core: Allow children node to be overridden")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Yes, this works. I have submitted an alternative patch to fix the
build error, changing the PHY core to not use any of the OF interfaces
if CONFIG_OF is disabled.

We can also have both.

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] of: Add stub for of_get_next_parent() Arnd Bergmann <arnd@arndb.de> - 2016-04-27 13:20 +0200
  Re: [PATCH] of: Add stub for of_get_next_parent() Thierry Reding <treding@nvidia.com> - 2016-04-27 17:10 +0200

csiph-web