Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389534 > unrolled thread

[PATCH v3] char/rtc: replace blacklist with whitelist

Back to article view | Back to linux.kernel

Contents

  [PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-04-27 21:50 +0200
    Re: [PATCH v3] char/rtc: replace blacklist with whitelist Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-27 22:00 +0200
      Re: [PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-04-27 22:10 +0200
    Re: [PATCH v3] char/rtc: replace blacklist with whitelist Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-01 22:30 +0200
      Re: [PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-05-01 23:00 +0200

#1389534 — [PATCH v3] char/rtc: replace blacklist with whitelist

Every new architecture has to add itself to the growing list of those
that do not support the legacy PC RTC driver.

This replaces the long list of architectures that don't support it
with a shorter list of those that do.

The list is taken from those architectures that have a non-empty
asm/mc146818rtc.h header file and were not explicitly blacklisted
or select RTC_LIB.

Alpha and Loongson64 can already choose between this driver and
an rtc-class based one. mn10300 is actually the only architecture
now that still requires this driver, and that should be fairly
easy to change to use rtc-cmos if we want to kill off rtc.ko
for good.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
This time I've trimmed down the whitelist even more, and separate
the patch from the other ones that are now all about the GEN_RTC
driver.

 drivers/char/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 3ec0766ed5e9..ca397384dc15 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -279,8 +279,7 @@ if RTC_LIB=n
 
 config RTC
 	tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
-	depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
-			&& !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
+	depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300
 	---help---
 	  If you say Y here and create a character special file /dev/rtc with
 	  major number 10 and minor number 135 using mknod ("man mknod"), you
-- 
2.7.0

[toc] | [next] | [standalone]

#1389536

On Wed, Apr 27, 2016 at 9:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
>
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
>
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted
> or select RTC_LIB.
>
> Alpha and Loongson64 can already choose between this driver and
> an rtc-class based one. mn10300 is actually the only architecture
> now that still requires this driver, and that should be fairly
> easy to change to use rtc-cmos if we want to kill off rtc.ko
> for good.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,8 +279,7 @@ if RTC_LIB=n
>
>  config RTC
>         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> +       depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300

Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1389549

On Wednesday 27 April 2016 21:52:48 Geert Uytterhoeven wrote:
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -279,8 +279,7 @@ if RTC_LIB=n
> >
> >  config RTC
> >         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> > -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> > +       depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300
> 
> Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.
> 

I listed it intentionally, to make it clearer to the reader what is
going on. Actually MIPS as a dependency by itself would also be sufficient,
because that contains

	select RTC_LIB if !MACH_LOONGSON64

and RTC depends on !RTC_LIB.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1391863

On Wed, Apr 27, 2016 at 09:45:01PM +0200, Arnd Bergmann wrote:
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
> 
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
> 
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted
> or select RTC_LIB.
> 
> Alpha and Loongson64 can already choose between this driver and
> an rtc-class based one. mn10300 is actually the only architecture
> now that still requires this driver, and that should be fairly
> easy to change to use rtc-cmos if we want to kill off rtc.ko
> for good.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> This time I've trimmed down the whitelist even more, and separate
> the patch from the other ones that are now all about the GEN_RTC
> driver.

So this is safe to take on it's own and you are going to redo that
larger series?

confused,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1391880

On Sunday 01 May 2016 13:21:07 Greg Kroah-Hartman wrote:
> On Wed, Apr 27, 2016 at 09:45:01PM +0200, Arnd Bergmann wrote:
> > Every new architecture has to add itself to the growing list of those
> > that do not support the legacy PC RTC driver.
> > 
> > This replaces the long list of architectures that don't support it
> > with a shorter list of those that do.
> > 
> > The list is taken from those architectures that have a non-empty
> > asm/mc146818rtc.h header file and were not explicitly blacklisted
> > or select RTC_LIB.
> > 
> > Alpha and Loongson64 can already choose between this driver and
> > an rtc-class based one. mn10300 is actually the only architecture
> > now that still requires this driver, and that should be fairly
> > easy to change to use rtc-cmos if we want to kill off rtc.ko
> > for good.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > This time I've trimmed down the whitelist even more, and separate
> > the patch from the other ones that are now all about the GEN_RTC
> > driver.
> 
> So this is safe to take on it's own and you are going to redo that
> larger series?

What I tried to say here is that this patch is now completely
independent from the longer series, please apply it directly.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web