Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1389536

Re: [PATCH v3] char/rtc: replace blacklist with whitelist

Show all headers | View raw

On Wed, Apr 27, 2016 at 9:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Every new architecture has to add itself to the growing list of those
> that do not support the legacy PC RTC driver.
>
> This replaces the long list of architectures that don't support it
> with a shorter list of those that do.
>
> The list is taken from those architectures that have a non-empty
> asm/mc146818rtc.h header file and were not explicitly blacklisted
> or select RTC_LIB.
>
> Alpha and Loongson64 can already choose between this driver and
> an rtc-class based one. mn10300 is actually the only architecture
> now that still requires this driver, and that should be fairly
> easy to change to use rtc-cmos if we want to kill off rtc.ko
> for good.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -279,8 +279,7 @@ if RTC_LIB=n
>
>  config RTC
>         tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> -       depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> -                       && !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN && !UML
> +       depends on ALPHA || (MIPS && MACH_LOONGSON64) || MN10300

Minor nit: MACH_LOONGSON64 implies MIPS, so I think you can drop the latter.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-04-27 21:50 +0200
  Re: [PATCH v3] char/rtc: replace blacklist with whitelist Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-27 22:00 +0200
    Re: [PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-04-27 22:10 +0200
  Re: [PATCH v3] char/rtc: replace blacklist with whitelist Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-05-01 22:30 +0200
    Re: [PATCH v3] char/rtc: replace blacklist with whitelist Arnd Bergmann <arnd@arndb.de> - 2016-05-01 23:00 +0200

csiph-web