Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1385757 > unrolled thread

Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] unicore32: mm: Add missing parameter to  arch_vma_access_permitted Guenter Roeck <linux@roeck-us.net> - 2016-04-24 02:10 +0200
    Re: [PATCH] unicore32: mm: Add missing parameter to       arch_vma_access_permitted "Xuetao Guan" <gxt@mprc.pku.edu.cn> - 2016-04-24 14:50 +0200

#1385757 — Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

ping ... still not upstream.

On 03/21/2016 04:20 AM, Guenter Roeck wrote:
> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault’:
> mm/memory.c:3381: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘check_vma_flags’:
> mm/gup.c:456: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘vma_permits_fault’:
> mm/gup.c:640: error:
> 	too many arguments to function ‘arch_vma_access_permitted’
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   arch/unicore32/include/asm/mmu_context.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
>   }
>
>   static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> -		bool write, bool foreign)
> +		bool write, bool execute, bool foreign)
>   {
>   	/* by default, allow everything */
>   	return true;
>

[toc] | [next] | [standalone]

#1385811 — Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

> ping ... still not upstream.
I'm sorry.
I'll do it in next week.

Xuetao

>
> On 03/21/2016 04:20 AM, Guenter Roeck wrote:
>> unicore32 fails to compile with the following errors.
>>
>> mm/memory.c: In function 鈥榑_handle_mm_fault鈥�:
>> mm/memory.c:3381: error:
>> 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
>> mm/gup.c: In function 鈥榗heck_vma_flags鈥�:
>> mm/gup.c:456: error:
>> 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
>> mm/gup.c: In function 鈥榲ma_permits_fault鈥�:
>> mm/gup.c:640: error:
>> 	too many arguments to function 鈥榓rch_vma_access_permitted鈥�
>>
>> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
>> fetches")
>> Cc: Dave Hansen <dave.hansen@linux.intel.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   arch/unicore32/include/asm/mmu_context.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/unicore32/include/asm/mmu_context.h
>> b/arch/unicore32/include/asm/mmu_context.h
>> index e35632ef23c7..62dfc644c908 100644
>> --- a/arch/unicore32/include/asm/mmu_context.h
>> +++ b/arch/unicore32/include/asm/mmu_context.h
>> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
>> *mm,
>>   }
>>
>>   static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> -		bool write, bool foreign)
>> +		bool write, bool execute, bool foreign)
>>   {
>>   	/* by default, allow everything */
>>   	return true;
>>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web