Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1385757
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted |
| Date | 2016-04-24 02:10 +0200 |
| Message-ID | <rrfMB-3u5-1@gated-at.bofh.it> (permalink) |
| References | <rf6c2-4QM-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
ping ... still not upstream.
On 03/21/2016 04:20 AM, Guenter Roeck wrote:
> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault’:
> mm/memory.c:3381: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘check_vma_flags’:
> mm/gup.c:456: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘vma_permits_fault’:
> mm/gup.c:640: error:
> too many arguments to function ‘arch_vma_access_permitted’
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/unicore32/include/asm/mmu_context.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
> }
>
> static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> - bool write, bool foreign)
> + bool write, bool execute, bool foreign)
> {
> /* by default, allow everything */
> return true;
>
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted Guenter Roeck <linux@roeck-us.net> - 2016-04-24 02:10 +0200 Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted "Xuetao Guan" <gxt@mprc.pku.edu.cn> - 2016-04-24 14:50 +0200
csiph-web