Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383332 > unrolled thread

Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci objects < 4.0

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci  objects < 4.0 Horia Ioan Geanta Neag <horia.geanta@nxp.com> - 2016-04-20 14:20 +0200
    RE: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci  objects < 4.0 Stuart Yoder <stuart.yoder@nxp.com> - 2016-04-20 17:30 +0200

#1383332 — Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci objects < 4.0

On 4/11/2016 7:50 PM, Stuart Yoder wrote:
> From: Horia Geanta <horia.geanta@nxp.com>
> 
> dpseci objects < 4.0 are not coherent-- in spite of the fact
> that the MC reports them to be coherent in certain versions.
> Add a special case to set the no shareability flag for dpseci
> objects < 4.0.
> 
> Signed-off-by: Horia Geanta <horia.geanta@nxp.com>
> (Stuart: reworded commit message, updated comment in patch)
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>

Do we really need this?
First upstream dpsec driver will be for dpsec >= v4.0.

Thanks,
Horia

> ---
>  drivers/staging/fsl-mc/bus/dprc-driver.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
> index 53c6e98..7fc4717 100644
> --- a/drivers/staging/fsl-mc/bus/dprc-driver.c
> +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
> @@ -312,6 +312,15 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
>  				continue;
>  			}
>  
> +			/*
> +			 * add a quirk for all versions of dpsec < 4.0...none
> +			 * are coherent regardless of what the MC reports.
> +			 */
> +			if ((strcmp(obj_desc->type, "dpseci") == 0) &&
> +			    (obj_desc->ver_major < 4))
> +				obj_desc->flags |=
> +					DPRC_OBJ_FLAG_NO_MEM_SHAREABILITY;
> +
>  			irq_count += obj_desc->irq_count;
>  			dev_dbg(&mc_bus_dev->dev,
>  				"Discovered object: type %s, id %d\n",
> 

[toc] | [next] | [standalone]

#1383494

> -----Original Message-----
> From: Horia Ioan Geanta Neag
> Sent: Wednesday, April 20, 2016 6:42 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>; Jose Rivera <german.rivera@nxp.com>
> Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org;
> agraf@suse.de; arnd@arndb.de; Yang-Leo Li <leoyang.li@nxp.com>
> Subject: Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci objects < 4.0
> 
> On 4/11/2016 7:50 PM, Stuart Yoder wrote:
> > From: Horia Geanta <horia.geanta@nxp.com>
> >
> > dpseci objects < 4.0 are not coherent-- in spite of the fact
> > that the MC reports them to be coherent in certain versions.
> > Add a special case to set the no shareability flag for dpseci
> > objects < 4.0.
> >
> > Signed-off-by: Horia Geanta <horia.geanta@nxp.com>
> > (Stuart: reworded commit message, updated comment in patch)
> > Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
> 
> Do we really need this?
> First upstream dpsec driver will be for dpsec >= v4.0.

This has nothing to do with the dpsec driver, it's just trying
to be complete with potential MC firmware versions that
might be encountered.  There is supported MC firmware
(and example non-upstream Linux drivers) in customer hands
with dpsec < 4.0, and we are handling that case even if
encountering it is not likely (e.g. what if someone develops
their own driver?).

So let's keep this quirk for now.

Stuart

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web