Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci objects < 4.0

From	Horia Ioan Geanta Neag <horia.geanta@nxp.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci objects < 4.0
Date	2016-04-20 14:20 +0200
Message-ID	<rpZgS-7JT-15@gated-at.bofh.it> (permalink)
References	<rpZgS-7JT-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 4/11/2016 7:50 PM, Stuart Yoder wrote:
> From: Horia Geanta <horia.geanta@nxp.com>
> 
> dpseci objects < 4.0 are not coherent-- in spite of the fact
> that the MC reports them to be coherent in certain versions.
> Add a special case to set the no shareability flag for dpseci
> objects < 4.0.
> 
> Signed-off-by: Horia Geanta <horia.geanta@nxp.com>
> (Stuart: reworded commit message, updated comment in patch)
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>

Do we really need this?
First upstream dpsec driver will be for dpsec >= v4.0.

Thanks,
Horia

> ---
>  drivers/staging/fsl-mc/bus/dprc-driver.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
> index 53c6e98..7fc4717 100644
> --- a/drivers/staging/fsl-mc/bus/dprc-driver.c
> +++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
> @@ -312,6 +312,15 @@ int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev,
>  				continue;
>  			}
>  
> +			/*
> +			 * add a quirk for all versions of dpsec < 4.0...none
> +			 * are coherent regardless of what the MC reports.
> +			 */
> +			if ((strcmp(obj_desc->type, "dpseci") == 0) &&
> +			    (obj_desc->ver_major < 4))
> +				obj_desc->flags |=
> +					DPRC_OBJ_FLAG_NO_MEM_SHAREABILITY;
> +
>  			irq_count += obj_desc->irq_count;
>  			dev_dbg(&mc_bus_dev->dev,
>  				"Discovered object: type %s, id %d\n",
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci  objects < 4.0 Horia Ioan Geanta Neag <horia.geanta@nxp.com> - 2016-04-20 14:20 +0200
  RE: [PATCH 11/14] staging: fsl-mc: add quirk handling for dpseci  objects < 4.0 Stuart Yoder <stuart.yoder@nxp.com> - 2016-04-20 17:30 +0200

csiph-web