Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383447 > unrolled thread

[PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs

Started byJavier Martinez Canillas <javier@osg.samsung.com>
First post2016-04-20 16:40 +0200
Last post2016-04-26 00:30 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:40 +0200
    [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:40 +0200
      Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return  value Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-21 09:20 +0200
      Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return  value Wolfram Sang <wsa@the-dreams.de> - 2016-04-26 00:30 +0200
    Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-21 09:20 +0200
    Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Wolfram Sang <wsa@the-dreams.de> - 2016-04-26 00:30 +0200

#1383447 — [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-04-20 16:40 +0200
Subject[PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs
Message-ID<rq1sm-VS-19@gated-at.bofh.it>
The driver not always prints the error code in case of a failure but this
information can be very useful for debugging. So let's print if available.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Hello,

This patch and 2/2 were only build tested because I don't have access to
a board using this IP block. I just noticed these issues when comparing
the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently.

I think the patches are simple enough that is safe to pick them but of
course testing will be highly appreciated.

Best regards,
Javier

Changes in v2:
- Don't print the errno code on probe since it's already printed by the
  core. Suggested by Krzysztof Kozlowski.

 drivers/i2c/busses/i2c-s3c2410.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 362a6de54833..13f67df65c45 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -944,7 +944,7 @@ static int s3c24xx_i2c_cpufreq_transition(struct notifier_block *nb,
 		i2c_unlock_adapter(&i2c->adap);
 
 		if (ret < 0)
-			dev_err(i2c->dev, "cannot find frequency\n");
+			dev_err(i2c->dev, "cannot find frequency (%d)\n", ret);
 		else
 			dev_info(i2c->dev, "setting freq %d\n", got);
 	}
@@ -995,7 +995,8 @@ static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c)
 
 		ret = gpio_request(gpio, "i2c-bus");
 		if (ret) {
-			dev_err(i2c->dev, "gpio [%d] request failed\n", gpio);
+			dev_err(i2c->dev, "gpio [%d] request failed (%d)\n",
+				gpio, ret);
 			goto free_gpio;
 		}
 	}
-- 
2.5.5

[toc] | [next] | [standalone]

#1383452 — [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-04-20 16:40 +0200
Subject[PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Message-ID<rq1sn-VS-31@gated-at.bofh.it>
In reply to#1383447
The clk_prepare_enable() function can fail so check the return
value and propagate the error in case of a failure.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

Changes in v2:
- Don't print the errno code since that's already printed by the
  core when probe fails. Suggested by Krzysztof Kozlowski.

 drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 13f67df65c45..8a9ea0c1e41d 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
 
 	/* initialise the i2c controller */
 
-	clk_prepare_enable(i2c->clk);
+	ret = clk_prepare_enable(i2c->clk);
+	if (ret) {
+		dev_err(&pdev->dev, "I2C clock enable failed\n");
+		return ret;
+	}
+
 	ret = s3c24xx_i2c_init(i2c);
 	clk_disable(i2c->clk);
 	if (ret != 0) {
-- 
2.5.5

[toc] | [prev] | [next] | [standalone]

#1383904 — Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-04-21 09:20 +0200
SubjectRe: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Message-ID<rqh46-5he-15@gated-at.bofh.it>
In reply to#1383452
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Changes in v2:
> - Don't print the errno code since that's already printed by the
>   core when probe fails. Suggested by Krzysztof Kozlowski.
> 
>  drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)


Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1386962 — Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value

FromWolfram Sang <wsa@the-dreams.de>
Date2016-04-26 00:30 +0200
SubjectRe: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Message-ID<rrXaW-52q-13@gated-at.bofh.it>
In reply to#1383452

[Multipart message — attachments visible in raw view] — view raw

On Wed, Apr 20, 2016 at 10:37:56AM -0400, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied to for-next, thanks!

[toc] | [prev] | [next] | [standalone]

#1383902

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-04-21 09:20 +0200
Message-ID<rqh46-5he-9@gated-at.bofh.it>
In reply to#1383447
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The driver not always prints the error code in case of a failure but this
> information can be very useful for debugging. So let's print if available.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Hello,
> 
> This patch and 2/2 were only build tested because I don't have access to
> a board using this IP block. I just noticed these issues when comparing
> the i2c-s3c2410 driver with i2c-exynos5 where I did some fixes recently.
> 
> I think the patches are simple enough that is safe to pick them but of
> course testing will be highly appreciated.
> 
> Best regards,
> Javier
> 
> Changes in v2:
> - Don't print the errno code on probe since it's already printed by the
>   core. Suggested by Krzysztof Kozlowski.
> 
>  drivers/i2c/busses/i2c-s3c2410.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1386963

FromWolfram Sang <wsa@the-dreams.de>
Date2016-04-26 00:30 +0200
Message-ID<rrXaW-52q-15@gated-at.bofh.it>
In reply to#1383447

[Multipart message — attachments visible in raw view] — view raw

On Wed, Apr 20, 2016 at 10:37:55AM -0400, Javier Martinez Canillas wrote:
> The driver not always prints the error code in case of a failure but this
> information can be very useful for debugging. So let's print if available.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 

Applied to for-next, thanks!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web