Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1383452
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value |
| Date | 2016-04-20 16:40 +0200 |
| Message-ID | <rq1sn-VS-31@gated-at.bofh.it> (permalink) |
| References | <rq1sm-VS-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The clk_prepare_enable() function can fail so check the return
value and propagate the error in case of a failure.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Don't print the errno code since that's already printed by the
core when probe fails. Suggested by Krzysztof Kozlowski.
drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 13f67df65c45..8a9ea0c1e41d 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
/* initialise the i2c controller */
- clk_prepare_enable(i2c->clk);
+ ret = clk_prepare_enable(i2c->clk);
+ if (ret) {
+ dev_err(&pdev->dev, "I2C clock enable failed\n");
+ return ret;
+ }
+
ret = s3c24xx_i2c_init(i2c);
clk_disable(i2c->clk);
if (ret != 0) {
--
2.5.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:40 +0200
[PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:40 +0200
Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-21 09:20 +0200
Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Wolfram Sang <wsa@the-dreams.de> - 2016-04-26 00:30 +0200
Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-21 09:20 +0200
Re: [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Wolfram Sang <wsa@the-dreams.de> - 2016-04-26 00:30 +0200
csiph-web