Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381725 > unrolled thread
| Started by | Andrew Goodbody <andrew.goodbody@cambrionix.com> |
|---|---|
| First post | 2016-04-18 16:00 +0200 |
| Last post | 2016-04-20 17:00 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-18 16:00 +0200
Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs David Miller <davem@davemloft.net> - 2016-04-20 02:20 +0200
RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-20 10:50 +0200
Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs David Miller <davem@davemloft.net> - 2016-04-20 17:00 +0200
| From | Andrew Goodbody <andrew.goodbody@cambrionix.com> |
|---|---|
| Date | 2016-04-18 16:00 +0200 |
| Subject | [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs |
| Message-ID | <rphSx-6yD-5@gated-at.bofh.it> |
This is a fix for a NULL pointer dereference from cpsw which is triggered by having two slave PHYs attached to a cpsw network device. The problem is due to only maintaining a single reference to a PHY node in the prive data which gets overwritten by the second PHY probe. So move the PHY node reference to the individual slave data so that there is now one per slave. v1 had a problem that data->slaves was used before it had been filled in Andrew Goodbody (1): Prevent NUll pointer dereference with two PHYs on cpsw drivers/net/ethernet/ti/cpsw.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) -- 2.5.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-04-20 02:20 +0200 |
| Subject | Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs |
| Message-ID | <rpO27-7iv-13@gated-at.bofh.it> |
| In reply to | #1381725 |
From: Andrew Goodbody <andrew.goodbody@cambrionix.com> Date: Mon, 18 Apr 2016 14:53:25 +0100 > This is a fix for a NULL pointer dereference from cpsw which is triggered > by having two slave PHYs attached to a cpsw network device. The problem is > due to only maintaining a single reference to a PHY node in the prive data > which gets overwritten by the second PHY probe. So move the PHY node > reference to the individual slave data so that there is now one per slave. > > v1 had a problem that data->slaves was used before it had been filled in I already applied v1 the other day, so you need to send me a relative patch rather than a whole new one. Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Andrew Goodbody <andrew.goodbody@cambrionix.com> |
|---|---|
| Date | 2016-04-20 10:50 +0200 |
| Subject | RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs |
| Message-ID | <rpVZE-4XX-3@gated-at.bofh.it> |
| In reply to | #1382918 |
> -----Original Message----- > From: Andrew Goodbody <andrew.goodbody@cambrionix.com> > Date: Mon, 18 Apr 2016 14:53:25 +0100 > > > This is a fix for a NULL pointer dereference from cpsw which is > > triggered by having two slave PHYs attached to a cpsw network device. > > The problem is due to only maintaining a single reference to a PHY > > node in the prive data which gets overwritten by the second PHY probe. > > So move the PHY node reference to the individual slave data so that there > is now one per slave. > > > > v1 had a problem that data->slaves was used before it had been filled > > in > > I already applied v1 the other day, so you need to send me a relative patch > rather than a whole new one. > > Thanks. Sorry, I had no notification that this had happened. However I thought that the plan was to revert v1 and go with David Rivshin's patch instead. I'll see if I can create a revert in a little while. Andrew
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-04-20 17:00 +0200 |
| Subject | Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs |
| Message-ID | <rq1LI-13P-15@gated-at.bofh.it> |
| In reply to | #1383164 |
From: Andrew Goodbody <andrew.goodbody@cambrionix.com> Date: Wed, 20 Apr 2016 08:49:34 +0000 > Sorry, I had no notification that this had happened. However I > thought that the plan was to revert v1 and go with David Rivshin's > patch instead. I'll see if I can create a revert in a little while. Yes, that's fine.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web