Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1382918

Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs
Date 2016-04-20 02:20 +0200
Message-ID <rpO27-7iv-13@gated-at.bofh.it> (permalink)
References <rphSx-6yD-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Andrew Goodbody <andrew.goodbody@cambrionix.com>
Date: Mon, 18 Apr 2016 14:53:25 +0100

> This is a fix for a NULL pointer dereference from cpsw which is triggered
> by having two slave PHYs attached to a cpsw network device. The problem is
> due to only maintaining a single reference to a PHY node in the prive data
> which gets overwritten by the second PHY probe. So move the PHY node
> reference to the individual slave data so that there is now one per slave.
> 
> v1 had a problem that data->slaves was used before it had been filled in

I already applied v1 the other day, so you need to send me a relative
patch rather than a whole new one.

Thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-18 16:00 +0200
  Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer  dereference with two slave PHYs David Miller <davem@davemloft.net> - 2016-04-20 02:20 +0200
    RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference  with two slave PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-20 10:50 +0200
      Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer  dereference with two slave PHYs David Miller <davem@davemloft.net> - 2016-04-20 17:00 +0200

csiph-web