Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380757 > unrolled thread
| Started by | Panos Vlachos <panosvlchs@gmail.com> |
|---|---|
| First post | 2016-04-17 16:20 +0200 |
| Last post | 2016-04-18 10:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 2/2] Staging: Lustre: Fixed coding style issues Panos Vlachos <panosvlchs@gmail.com> - 2016-04-17 16:20 +0200
Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-04-17 23:40 +0200
Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues Joe Perches <joe@perches.com> - 2016-04-18 10:50 +0200
| From | Panos Vlachos <panosvlchs@gmail.com> |
|---|---|
| Date | 2016-04-17 16:20 +0200 |
| Subject | [PATCH 2/2] Staging: Lustre: Fixed coding style issues |
| Message-ID | <roVIm-5HD-15@gated-at.bofh.it> |
Fixed one coding style issue in the file router_proc.c (Lustre staging driver) Signed-off-by: Panos Vlachos <panosvlchs@gmail.com> --- drivers/staging/lustre/lnet/lnet/router_proc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c index 65f65a3..87afb40 100644 --- a/drivers/staging/lustre/lnet/lnet/router_proc.c +++ b/drivers/staging/lustre/lnet/lnet/router_proc.c @@ -32,7 +32,8 @@ */ #define LNET_PROC_CPT_BITS (LNET_CPT_BITS + 1) /* change version, 16 bits or 8 bits */ -#define LNET_PROC_VER_BITS max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) +#define LNET_PROC_VER_BITS \ +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) #define LNET_PROC_HASH_BITS LNET_PEER_HASH_BITS /* -- 1.9.1
[toc] | [next] | [standalone]
| From | "Drokin, Oleg" <oleg.drokin@intel.com> |
|---|---|
| Date | 2016-04-17 23:40 +0200 |
| Message-ID | <rp2Ab-2oz-29@gated-at.bofh.it> |
| In reply to | #1380757 |
On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote: > Fixed one coding style issue in the > file router_proc.c (Lustre staging driver) Perhaps it's best to reference what the issue is. I.e. "Fix too long line in …" and then in the actual message add that you just split it? > > Signed-off-by: Panos Vlachos <panosvlchs@gmail.com> > --- > drivers/staging/lustre/lnet/lnet/router_proc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c > index 65f65a3..87afb40 100644 > --- a/drivers/staging/lustre/lnet/lnet/router_proc.c > +++ b/drivers/staging/lustre/lnet/lnet/router_proc.c > @@ -32,7 +32,8 @@ > */ > #define LNET_PROC_CPT_BITS (LNET_CPT_BITS + 1) > /* change version, 16 bits or 8 bits */ > -#define LNET_PROC_VER_BITS max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) > +#define LNET_PROC_VER_BITS \ > +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) Hm, I am not sure this is an improvement, you might want to at least place a tab at the start of this second line, so that indentation helps us better see it's a continuation of the previous one. Thanks. > > #define LNET_PROC_HASH_BITS LNET_PEER_HASH_BITS > /* > -- > 1.9.1 >
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-04-18 10:50 +0200 |
| Message-ID | <rpd2y-2oe-21@gated-at.bofh.it> |
| In reply to | #1380846 |
On Sun, 2016-04-17 at 21:35 +0000, Drokin, Oleg wrote: > On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote: > > Fixed one coding style issue in the > > file router_proc.c (Lustre staging driver) > Perhaps it's best to reference what the issue is. > I.e. "Fix too long line in …" > and then in the actual message add that you just split it? [] > > diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c [] > > @@ -32,7 +32,8 @@ > > */ > > #define LNET_PROC_CPT_BITS (LNET_CPT_BITS + 1) > > /* change version, 16 bits or 8 bits */ > > -#define LNET_PROC_VER_BITS max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) > > +#define LNET_PROC_VER_BITS \ > > +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8) > Hm, I am not sure this is an improvement, you might want to at least place a tab at the start of this > second line, so that indentation helps us better see it's a continuation of the previous one. Given: #define LNET_LOFFT_BITS (sizeof(loff_t) * 8) and: include/linux/types.h:typedef __kernel_loff_t loff_t; include/uapi/asm-generic/posix_types.h:typedef long long __kernel_loff_t; and this isn't going to change any time soon, maybe this #define isn't particularly useful and #define LNET_PROC_VER_BITS 16 is sufficient.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web