Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380846

Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues

Show all headers | View raw

On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote:

> Fixed one coding style issue in the
> file router_proc.c (Lustre staging driver)

Perhaps it's best to reference what the issue is.
I.e. "Fix too long line in …"
and then in the actual message add that you just split it?
> 
> Signed-off-by: Panos Vlachos <panosvlchs@gmail.com>
> ---
> drivers/staging/lustre/lnet/lnet/router_proc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c
> index 65f65a3..87afb40 100644
> --- a/drivers/staging/lustre/lnet/lnet/router_proc.c
> +++ b/drivers/staging/lustre/lnet/lnet/router_proc.c
> @@ -32,7 +32,8 @@
>  */
> #define LNET_PROC_CPT_BITS	(LNET_CPT_BITS + 1)
> /* change version, 16 bits or 8 bits */
> -#define LNET_PROC_VER_BITS	max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8)
> +#define LNET_PROC_VER_BITS	\
> +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8)

Hm, I am not sure this is an improvement, you might want to at least place a tab at the start of this
second line, so that indentation helps us better see it's a continuation of the previous one.

Thanks.

> 
> #define LNET_PROC_HASH_BITS	LNET_PEER_HASH_BITS
> /*
> -- 
> 1.9.1
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] Staging: Lustre: Fixed coding style issues Panos Vlachos <panosvlchs@gmail.com> - 2016-04-17 16:20 +0200
  Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-04-17 23:40 +0200
    Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues Joe Perches <joe@perches.com> - 2016-04-18 10:50 +0200

csiph-web