Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380575 > unrolled thread
| Started by | David Lechner <david@lechnology.com> |
|---|---|
| First post | 2016-04-16 19:10 +0200 |
| Last post | 2016-04-25 18:30 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2 0/4] More small davinci device tree fixes David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
[PATCH v2 4/4] ARM: davinci: da850: There are 101 interrupts. David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
[PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi Sekhar Nori <nsekhar@ti.com> - 2016-04-25 15:40 +0200
Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi David Lechner <david@lechnology.com> - 2016-04-25 18:30 +0200
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2016-04-16 19:10 +0200 |
| Subject | [PATCH v2 0/4] More small davinci device tree fixes |
| Message-ID | <roBTj-72V-3@gated-at.bofh.it> |
Split "ARM: davinci: add spi0 to da850 device tree" into two patches and added pinmux device tree nodes. David Lechner (4): ARM: DTS: da850: add spi0 to device tree ARM: davinci: Add spi0 lookup to da8xx-dt for clock matching ARM: davinci: disable mdio and eth0 in da850.dtsi ARM: davinci: da850: There are 101 interrupts. arch/arm/boot/dts/da850-enbw-cmc.dts | 6 ++++++ arch/arm/boot/dts/da850.dtsi | 28 ++++++++++++++++++++++++++-- arch/arm/mach-davinci/da8xx-dt.c | 1 + 3 files changed, 33 insertions(+), 2 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2016-04-16 19:10 +0200 |
| Subject | [PATCH v2 4/4] ARM: davinci: da850: There are 101 interrupts. |
| Message-ID | <roBTk-72V-19@gated-at.bofh.it> |
| In reply to | #1380575 |
Fix off by one error in da850 device tree. Signed-off-by: David Lechner <david@lechnology.com> Tested-by: Kevin Hilman <khilman@baylibre.com> --- no change arch/arm/boot/dts/da850.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 26fc0812..cf1aad8 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -19,7 +19,7 @@ compatible = "ti,cp-intc"; interrupt-controller; #interrupt-cells = <1>; - ti,intc-size = <100>; + ti,intc-size = <101>; reg = <0xfffee000 0x2000>; }; }; -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2016-04-16 19:10 +0200 |
| Subject | [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi |
| Message-ID | <roBTk-72V-23@gated-at.bofh.it> |
| In reply to | #1380575 |
All other devices are disabled by default and not all boards will use
these devices, so these should be disabled too..
da850-evm.dtb already had status = "okay" for these devices.
da850-enbw-cmc.dts did not, so they were added.
Signed-off-by: David Lechner <david@lechnology.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
---
no change
arch/arm/boot/dts/da850-enbw-cmc.dts | 6 ++++++
arch/arm/boot/dts/da850.dtsi | 2 ++
2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/da850-enbw-cmc.dts b/arch/arm/boot/dts/da850-enbw-cmc.dts
index 101d1a1..14dff3e 100644
--- a/arch/arm/boot/dts/da850-enbw-cmc.dts
+++ b/arch/arm/boot/dts/da850-enbw-cmc.dts
@@ -26,6 +26,12 @@
serial2: serial@10d000 {
status = "okay";
};
+ mdio: mdio@224000 {
+ status = "okay";
+ };
+ eth0: ethernet@220000 {
+ status = "okay";
+ };
};
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 8880d57..26fc0812 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -330,6 +330,7 @@
#address-cells = <1>;
#size-cells = <0>;
reg = <0x224000 0x1000>;
+ status = "disabled";
};
eth0: ethernet@220000 {
compatible = "ti,davinci-dm6467-emac";
@@ -344,6 +345,7 @@
35
36
>;
+ status = "disabled";
};
gpio: gpio@226000 {
compatible = "ti,dm6441-gpio";
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2016-04-25 15:40 +0200 |
| Subject | Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi |
| Message-ID | <rrOU4-6G6-49@gated-at.bofh.it> |
| In reply to | #1380577 |
Hi David,
On Saturday 16 April 2016 10:30 PM, David Lechner wrote:
> All other devices are disabled by default and not all boards will use
> these devices, so these should be disabled too..
>
> da850-evm.dtb already had status = "okay" for these devices.
> da850-enbw-cmc.dts did not, so they were added.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
I applied this and other patches in this series. One nit-pick though.
The commit description should be independently readable and not only as
continuation of the headline. Even if this means repeating portion of
the headline. I fixed this for most of the patches in this series. For
example, for this patch, I have:
ARM: dts: da850: disable mdio and eth0 in da850.dtsi
Disable mdio and eth0 in da850.dtsi file. All other
devices are disabled by default and not all boards
will use these devices, so these should be disabled too.
da850-evm.dtb already had status = "okay" for these devices.
da850-enbw-cmc.dts did not, so they were added.
Signed-off-by: David Lechner <david@lechnology.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
[nsekhar@ti.com: commit description updates]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Its a minor change and I wont reply to all the patches with the changes
I made. But I pushed the updated v4.7/dt branch in my tree. Do take a
look at the commit description there.
Thanks,
Sekhar
[toc] | [prev] | [next] | [standalone]
| From | David Lechner <david@lechnology.com> |
|---|---|
| Date | 2016-04-25 18:30 +0200 |
| Subject | Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi |
| Message-ID | <rrRyz-t4-37@gated-at.bofh.it> |
| In reply to | #1386453 |
On 04/25/2016 08:30 AM, Sekhar Nori wrote: > Hi David, > > On Saturday 16 April 2016 10:30 PM, David Lechner wrote: >> All other devices are disabled by default and not all boards will use >> these devices, so these should be disabled too.. >> >> da850-evm.dtb already had status = "okay" for these devices. >> da850-enbw-cmc.dts did not, so they were added. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> Tested-by: Kevin Hilman <khilman@baylibre.com> > > I applied this and other patches in this series. One nit-pick though. > The commit description should be independently readable and not only as > continuation of the headline. Even if this means repeating portion of > the headline. I fixed this for most of the patches in this series. For > example, for this patch, I have: > > ARM: dts: da850: disable mdio and eth0 in da850.dtsi > > Disable mdio and eth0 in da850.dtsi file. All other > devices are disabled by default and not all boards > will use these devices, so these should be disabled too. > > da850-evm.dtb already had status = "okay" for these devices. > da850-enbw-cmc.dts did not, so they were added. > > Signed-off-by: David Lechner <david@lechnology.com> > Tested-by: Kevin Hilman <khilman@baylibre.com> > [nsekhar@ti.com: commit description updates] > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > > Its a minor change and I wont reply to all the patches with the changes > I made. But I pushed the updated v4.7/dt branch in my tree. Do take a > look at the commit description there. > > Thanks, > Sekhar > > I had a look at the commits. I'll be sure to follow that advice in the future.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web