Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1386645

Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi

Show all headers | View raw

On 04/25/2016 08:30 AM, Sekhar Nori wrote:
> Hi David,
>
> On Saturday 16 April 2016 10:30 PM, David Lechner wrote:
>> All other devices are disabled by default and not all boards will use
>> these devices, so these should be disabled too..
>>
>> da850-evm.dtb already had status = "okay" for these devices.
>> da850-enbw-cmc.dts did not, so they were added.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> Tested-by: Kevin Hilman <khilman@baylibre.com>
>
> I applied this and other patches in this series. One nit-pick though.
> The commit description should be independently readable and not only as
> continuation of the headline. Even if this means repeating portion of
> the headline. I fixed this for most of the patches in this series. For
> example, for this patch, I have:
>
>      ARM: dts: da850: disable mdio and eth0 in da850.dtsi
>
>      Disable mdio and eth0 in da850.dtsi file. All other
>      devices are disabled by default and not all boards
>      will use these devices, so these should be disabled too.
>
>      da850-evm.dtb already had status = "okay" for these devices.
>      da850-enbw-cmc.dts did not, so they were added.
>
>      Signed-off-by: David Lechner <david@lechnology.com>
>      Tested-by: Kevin Hilman <khilman@baylibre.com>
>      [nsekhar@ti.com: commit description updates]
>      Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>
> Its a minor change and I wont reply to all the patches with the changes
> I made. But I pushed the updated v4.7/dt branch in my tree. Do take a
> look at the commit description there.
>
> Thanks,
> Sekhar
>
>


I had a look at the commits. I'll be sure to follow that advice in the 
future.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] More small davinci device tree fixes David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
  [PATCH v2 4/4] ARM: davinci: da850: There are 101 interrupts. David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
  [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi David Lechner <david@lechnology.com> - 2016-04-16 19:10 +0200
    Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi Sekhar Nori <nsekhar@ti.com> - 2016-04-25 15:40 +0200
      Re: [PATCH v2 3/4] ARM: davinci: disable mdio and eth0 in da850.dtsi David Lechner <david@lechnology.com> - 2016-04-25 18:30 +0200

csiph-web