Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1378128 > unrolled thread

[PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-13 19:40 +0200
    Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header Mark Brown <broonie@kernel.org> - 2016-04-14 08:50 +0200

#1378128 — [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header

This patch adds dummy function for regmap_can_raw_write() in the header
file, so that the code can be atleast compiled without regmap enabled.
This kind of setup is mostly tested using randomconfig or zero
day-testing.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 include/linux/regmap.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index be3da4c..c060b9b 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -1052,6 +1052,12 @@ static inline bool regmap_can_raw_read(struct regmap *map)
 	return false;
 }
 
+static inline bool regmap_can_raw_write(struct regmap *map)
+{
+	WARN_ONCE(1, "regmap API is disabled");
+	return false;
+}
+
 static inline int regmap_register_patch(struct regmap *map,
 					const struct reg_sequence *regs,
 					int num_regs)
-- 
2.5.0

[toc] | [next] | [standalone]

#1378526

[Multipart message — attachments visible in raw view] — view raw

On Wed, Apr 13, 2016 at 06:39:13PM +0100, Srinivas Kandagatla wrote:
> This patch adds dummy function for regmap_can_raw_write() in the header
> file, so that the code can be atleast compiled without regmap enabled.
> This kind of setup is mostly tested using randomconfig or zero
> day-testing.

I'm not convinced that this isn't flagging real problems - it's hard to
see how code can safely and sensibly be written which would use this
without a dependency on regmap (and given that and the fact that we have
no external users we should probably make it internal to the API).

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web