Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1378526

Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 13, 2016 at 06:39:13PM +0100, Srinivas Kandagatla wrote:
> This patch adds dummy function for regmap_can_raw_write() in the header
> file, so that the code can be atleast compiled without regmap enabled.
> This kind of setup is mostly tested using randomconfig or zero
> day-testing.

I'm not convinced that this isn't flagging real problems - it's hard to
see how code can safely and sensibly be written which would use this
without a dependency on regmap (and given that and the fact that we have
no external users we should probably make it internal to the API).

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-04-13 19:40 +0200
  Re: [PATCH v1 2/3] regmap: add dummy regmap_can_raw_write() to header Mark Brown <broonie@kernel.org> - 2016-04-14 08:50 +0200

csiph-web