Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1377814 > unrolled thread

[PATCH 1/2] vfs: Define new syscall getumask.

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/2] vfs: Define new syscall getumask. "Richard W.M. Jones" <rjones@redhat.com> - 2016-04-13 13:50 +0200
    Re: [PATCH 1/2] vfs: Define new syscall getumask. Florian Weimer <fw@deneb.enyo.de> - 2016-04-13 14:50 +0200
      Re: [PATCH 1/2] vfs: Define new syscall getumask. Cyrill Gorcunov <gorcunov@gmail.com> - 2016-04-13 14:50 +0200

#1377814 — [PATCH 1/2] vfs: Define new syscall getumask.

Define a system call for reading the current umask value.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 include/linux/syscalls.h | 1 +
 kernel/sys.c             | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index d795472..e96e88f 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -659,6 +659,7 @@ asmlinkage long sys_prlimit64(pid_t pid, unsigned int resource,
 				struct rlimit64 __user *old_rlim);
 asmlinkage long sys_getrusage(int who, struct rusage __user *ru);
 asmlinkage long sys_umask(int mask);
+asmlinkage long sys_getumask(void);
 
 asmlinkage long sys_msgget(key_t key, int msgflg);
 asmlinkage long sys_msgsnd(int msqid, struct msgbuf __user *msgp,
diff --git a/kernel/sys.c b/kernel/sys.c
index cf8ba54..026c146 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1649,6 +1649,11 @@ SYSCALL_DEFINE1(umask, int, mask)
 	return mask;
 }
 
+SYSCALL_DEFINE0(getumask)
+{
+	return current->fs->umask;
+}
+
 static int prctl_set_mm_exe_file(struct mm_struct *mm, unsigned int fd)
 {
 	struct fd exe;
-- 
2.7.4

[toc] | [next] | [standalone]

#1377895

* Richard W. M. Jones:

> +SYSCALL_DEFINE0(getumask)
> +{
> +	return current->fs->umask;
> +}

The convention seems to be to call current_umask(), instead of
inlining its contents.

[toc] | [prev] | [next] | [standalone]

#1377898

On Wed, Apr 13, 2016 at 02:21:35PM +0200, Florian Weimer wrote:
> * Richard W. M. Jones:
> 
> > +SYSCALL_DEFINE0(getumask)
> > +{
> > +	return current->fs->umask;
> > +}
> 
> The convention seems to be to call current_umask(), instead of
> inlining its contents.

Yes, please use existing.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web